This repository has been archived by the owner on Apr 11, 2023. It is now read-only.
Destroy model with temp id #115
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 22, 2014 12:17
When a model with a temp id is destroyed, then the success and error callbacks should be invoked too.
If a model with a temp id is destroyed, it should not be marked as destroyed. Because it has never been synced with the server.
| @@ -205,7 +205,7 @@ localsync = (method, model, options) -> | |||
| store.clean(model, 'dirty') | |||
| when 'delete' | |||
| store.destroy(model) | |||
| if options.dirty | |||
| if options.dirty && !model.hasTempId() | |||
| store.destroyed(model) | |||
| else | |||
| if model.id.toString().length == 36 | |||
There was a problem hiding this comment.
Good call. While looking at this, I noticed also that line 211 should use hasTempId().
|
Thanks @DatenMetzgerX ! Good find and fix. I rewrote each commit to include an amd build (ran |
nilbus
added a commit
that referenced
this pull request
Jun 23, 2014
nilbus
added a commit
that referenced
this pull request
Jun 24, 2014
|
Released in v1.4.0. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a model with a temp id is destroyed, then the callbacks should be invoked too.