forked from binary-com/deriv-app
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[CRO] Amir/cro 333/ab test for onboarding toggle (binary-com#13545)
* chore: add ab test for skip onboarding flow * chore: add test case for feature flag hook * chore: add mock of analytics package on onboarding * chore: resolve review comments * chore: update package version to 1.4.11 * chore: change var name * fix: show onboarding as normal after login * fix: onboarding ab test flow issue on normal scenario * chore: fix eslint error * chore: downgrade package version to 1.4.10 * chore: update lock
- Loading branch information
1 parent
a7ef2ed
commit 4f4fe75
Showing
8 changed files
with
140 additions
and
56 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31 changes: 31 additions & 0 deletions
31
packages/hooks/src/__tests__/useGrowthbookFeatureFlag.spec.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
import { renderHook } from '@testing-library/react-hooks'; | ||
import useGrowthbookFeatureFlag from '../useGrowthbookFeatureFlag'; | ||
import { Analytics } from '@deriv-com/analytics'; | ||
|
||
describe('useGrowthbookFeatureFlag', () => { | ||
test('Should call getFeatureValue from the package', async () => { | ||
const { result } = renderHook(() => | ||
useGrowthbookFeatureFlag({ | ||
defaultValue: false, | ||
featureFlag: 'dummy-feature-flag', | ||
}) | ||
); | ||
|
||
expect(result.current).toBe(false); | ||
expect(Analytics.getFeatureValue).toHaveBeenCalled(); | ||
expect(Analytics.getFeatureValue).toHaveBeenCalledWith('dummy-feature-flag', false); | ||
}); | ||
|
||
test('The default value for the feature flag must be sent correctly to the package', async () => { | ||
const { result } = renderHook(() => | ||
useGrowthbookFeatureFlag({ | ||
defaultValue: true, | ||
featureFlag: 'dummy-feature-flag-1', | ||
}) | ||
); | ||
|
||
expect(result.current).toBe(true); | ||
expect(Analytics.getFeatureValue).toHaveBeenCalled(); | ||
expect(Analytics.getFeatureValue).toHaveBeenCalledWith('dummy-feature-flag-1', true); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
import { useState, useEffect } from 'react'; | ||
import { Analytics } from '@deriv-com/analytics'; | ||
|
||
interface UseGrowthbookFeatureFlagArgs<T> { | ||
featureFlag: string; | ||
defaultValue: T; | ||
} | ||
|
||
const useGrowthbookFeatureFlag = <T>({ featureFlag, defaultValue }: UseGrowthbookFeatureFlagArgs<T>) => { | ||
const [featureFlagValue, setFeatureFlagValue] = useState<T>(defaultValue); | ||
|
||
useEffect(() => { | ||
const value = (Analytics?.getFeatureValue(featureFlag, defaultValue) || defaultValue) as T; | ||
setFeatureFlagValue(value); | ||
|
||
// Set the renderer for GrowthBook to update the value when the feature flag changes | ||
Analytics.getInstances()?.ab?.GrowthBook?.setRenderer(() => { | ||
const value = (Analytics?.getFeatureValue(featureFlag, defaultValue) || defaultValue) as T; | ||
|
||
setFeatureFlagValue(value); | ||
}); | ||
}, [featureFlag, defaultValue]); | ||
|
||
return featureFlagValue; | ||
}; | ||
|
||
export default useGrowthbookFeatureFlag; |