Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: packages shared utils array ts migration #80

Merged
merged 4 commits into from
Feb 21, 2023
Merged

refactor: packages shared utils array ts migration #80

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a9c669d
refactor: packages shared utils array ts migration
Feb 20, 2023
aae71fd
refactor: array check remove
Feb 21, 2023
28168ca
refactor: function returned to arrow
Feb 21, 2023
def91ad
refactor: function returned to arrow
Feb 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/shared/src/utils/array/array.js → packages/shared/src/utils/array/array.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
export const shuffleArray = array => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yauheni-deriv, Just a question, Why did you decide to switch from the arrow function?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had error while trying to apply generic on arrow functions
https://www.typescriptlang.org/docs/handbook/2/functions.html

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There shouldn’t be any issues 🤔 Although it doesn’t matter and we can move forward 🙇🏻

export const shuffleArray = <T>(array: T[]): T[] => {
    for (let i = array.length - 1; i > 0; i--) {
        const j = Math.floor(Math.random() * (i + 1));
        [array[i], array[j]] = [array[j], array[i]];
    }

    return array;
};

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. will change it. I guess I just missed something while refactoring. it works fine

export function shuffleArray<T>(array: T[]): T[] {
if (Array.isArray(array)) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check can be removed

for (let i = array.length - 1; i > 0; i--) {
const j = Math.floor(Math.random() * (i + 1));
[array[i], array[j]] = [array[j], array[i]];
}
}
return array;
};
}
0 packages/shared/src/utils/array/index.js → packages/shared/src/utils/array/index.ts
View file
Open in desktop
File renamed without changes.