Likhith/74106/migrate file uploader #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added modal manager component (deriv-com#6768) * farrah/81373/lazy loading in p2p (deriv-com#6907) * perf: configured webpack for lazy loading * added css lazy loading * fix: fixed missing css * refactor: myAdsFloatingRateSwitchModal (deriv-com#7173) * refactor: emailLinkVerifiedModal (deriv-com#7118) * refactor: myAdsDeleteModal (deriv-com#7024) * refactor: adExceedsDailyLimitModal (deriv-com#7027) * farrah/78909/refactor FilterModal (deriv-com#6906) * refactor filter modal * perf: added lazy loading * fix: added publicPath * farrah/78919/refactor OrderDetailsCancelModal (deriv-com#7018) * refactor: order details cancel modal * fix: tests * Adrienne / BuySellModal and CancelAddPaymentMethodModal component with saved form state component (deriv-com#7077) * saved draft * Refactored out cleanupFn argument in hideModal * fix: added modal form and saving state * fixed issues with mobile stacking modal * refactored out comments * refactor: remove cancel add payment method modal from my profile * removed add payment method modal in my profile * removed icons.js * removed icons.js * refactor: fix import path for modal form * refactor: fix import path for modal form * refactor: fix import path for modal form * chore: reverted change on cancel add payment method modal in my profile folder * chore: refactored code * chore: revert * Fix merge conflicts * Adrienne / Refactored Create Ad Add Payment Method Modal and Add Payment Method Error Modal (deriv-com#7210) * chore: fixed issues with dropdown detecting as clicking outside modal * chore: updated branch with drafted branch * chore: added sycned branch changes * farrah/78918/refactor EmailVerificationModal (deriv-com#7056) * refactor: emailVerificationModal * Refactored out EmailLinkVerifiedModal since that related modal card is merged to p2p-modal-manager * Refactored out EmailLinkVerifiedModal observables Co-authored-by: adrienne-deriv <103016120+adrienne-deriv@users.noreply.github.com> * farrah/78920/refactor OrderDetailsConfirmModal (deriv-com#7038) * refactor: orderDetailsConfirmModal * refactor: onClick handler * chore: fix issues with build after merge conflicts Co-authored-by: adrienne-deriv <103016120+adrienne-deriv@users.noreply.github.com> * farrah/78927/refactor EditAdCancelModal (deriv-com#7122) * refactor: editAdCancelModal * Refactored out CreateAdAddPaymentMethodModal since its already merged to p2p-modal-manager Co-authored-by: adrienne-deriv <103016120+adrienne-deriv@users.noreply.github.com> * farrah/78925/refactor CreateAdErrorModal (deriv-com#7052) * refactor: createAdErrorModal * chore: fixed merge conflict issues Co-authored-by: adrienne-deriv <103016120+adrienne-deriv@users.noreply.github.com> * Adrienne / Rating modal and Recommended modal (deriv-com#7132) * saved draft * refactor: added rating modal * added recommended modal * refactored code * refactored code * refactor: fixed issues with test * fix: added mock function for useModalManagerContext in app content test * refactored out comment for should_show_rating_modal * refactor: refactored out props for rating modal * chore: removed modal props on cleanup * chore: fixed issues with test * chore: refactor based on reviews * chore: refactor * Adrienne / Refactored Delete Payment Method Error modal and Cancel Edit Payment method modal (deriv-com#7222) * saved draft * refactor: added delete payment method error modal * chore: fixed an issue where payment methods are not listed for sell ads * chore: fixed issue where back button does not trigger cancel edit pm modal * farrah/78916/refactor InvalidVerificationLinkModal (deriv-com#7017) * refactor: invalid verification link modal * refactor: error message * chore: fixed merge conflicts Co-authored-by: adrienne-deriv <103016120+adrienne-deriv@users.noreply.github.com> * Adrienne / Error modal (deriv-com#7283) * saved draft * refactor: added error modal * chore: reverted old changes modals folder * Adrienne / Currency Selector modal (deriv-com#7279) * saved draft * refactor: added currency selector modal * chore: revert old changes modals folder * Adrienne / Block User Modal (deriv-com#7276) * saved draft * refactor: added block user modal * chore: fix issues with test build * chore: removed comments * chore: updated comment * chore: fixed issues with running build * chore: fixed issues with running test * refactor: loading modal (deriv-com#7006) Co-authored-by: adrienne-deriv <103016120+adrienne-deriv@users.noreply.github.com> * Adrienne / Rate Change Modal (deriv-com#7266) * saved draft * refactor: added rate change modal * chore: changed isRateChanged function * chore: refactored hideModal with options * chore: reverted comments * chore: refactored naming options for hidemodal * Adrienne / Quick Add Modal and integrating new payment method dropdown component for buy ads in the modal (deriv-com#7308) * saved draft * refactor: added quick add modal and new dropdown component * chore: refactored out unusesd files * chore: reverted merge conflict issues * chore: removed old merge conflicts * chore: fixed merge conflicts and added 2 new modals * chore: reverted refactor and used error modal instead * farrah/78906/refactor MarketRateChangeErrorModal (deriv-com#7357) * refactor: market rate change error modal * refactor: code * refactor: unnecessary code * refactor: fixed issues with buy ad payment methods list Co-authored-by: adrienne-rio <adrienne@deriv.com> * fix: conflicts * fix: conflicts * Adrienne / Wrong popup message counterparty block user modal (deriv-com#7459) * saved draft * fix: fixed an issue where incorrect block user modal message is shown in block user list * chore: removed old commits * Adrienne / Fix issue verification link modal showing twice (deriv-com#7545) * saved draft * fix: verification modal now shows once * Adrienne / Add payment method not dismissed create ad (deriv-com#7505) * saved draft * fix: create ad add payment method modal now closes when user adds a pm * chore: removed old commits * chore: added multiple arguments for iscurrentmodal * Adrienne / Market rate change popup not displayed (deriv-com#7478) * saved draft * fix: fixed an issue where rate change modal is not shown when user changes to different currency * chore: removed old commits * Adrienne / Fixed issue with block user error modal (deriv-com#7539) * saved draft * fix: reset error status * chore: removed old commits * fix: fixed an issue where the error modal is displayed twice * Adrienne / Fix bug in buy sell header and refactored code (deriv-com#7624) * saved draft * refactor: refactored buy sell modal header * chore: removed comments * chore: applied code review refactors --------- Co-authored-by: adrienne-deriv <103016120+adrienne-deriv@users.noreply.github.com> Co-authored-by: adrienne-rio <adrienne@deriv.com>
* fix: Unable to add CR fiat account * fix: Unable to add CR fiat account
…ing (deriv-com#7431) * fix: delete some console errors * fix: move spanButton to components package * fix: export TButtonProps * fix: put div putside p and use SpanButton instead of Button * fix: remove React.FC from SpanButton
… account (deriv-com#7633) * fix: add button for adding account * fix: convert total assets for demo in account currency * fix: add check for restricted_countries for is_high function in client-store * Update packages/core/src/Stores/client-store.js Co-authored-by: Matin shafiei <matin@binary.com> * Update packages/core/src/Stores/client-store.js Co-authored-by: mahdiyeh-deriv <82078941+mahdiyeh-deriv@users.noreply.github.com> * chore: empty * fix: delete unnecessary '`' * refactor: change restricted_countries * chore: empty * fix: demo account total assets is always USD * fix: delete 'add or manage account' by checking 'filtered_remaining_real_accounts' length --------- Co-authored-by: Matin shafiei <matin@deriv.com> Co-authored-by: Matin shafiei <matin@binary.com> Co-authored-by: mahdiyeh-deriv <82078941+mahdiyeh-deriv@users.noreply.github.com> Co-authored-by: Jim Daniels Wasswa <104334373+jim-deriv@users.noreply.github.com>
* fix: exit traders hub * fix: remove is_currency_switcher_disabled_for_mf from the currency switcher dropdown
…for low risk (deriv-com#7519) * fix: exit traders hub * fix: When login back to the account with has EU only the data for MF is showing * fix: exit from non-eu from traders hub, multipliers is still the active account
* chore: change stylings add more padding below to how content in different screen size 📱 * fix: scroll issue on smaller screens * feat: testing sikit * fix: change onboarding sizing to fit mobile * fix: remove max-height on footer * fix: added more height to the body * fix: readjust body height (again😀)
…er Non EU Deriv Account when inside of Traders Hub (deriv-com#7648) * fix: add crypto for EU * fix: change modal height and define crypto array --------- Co-authored-by: amina-deriv <84661147+amina-deriv@users.noreply.github.com>
…8920/ts-migration-parent
…88920/ts-migration-parent
…er (deriv-com#7657) * fix: add and manage account button logic in account switcher * fix: account switcher for low risk * fix: mockstore * fix: account switcher for the final time hopefully * redeploy: a * fix: deriv api versioning * fix: account switcher outside traders hub * fix: manage accounts text change
…is not possible (deriv-com#7709) * fix: transfer form crypto to fiat * fix: display transferred amount in thousands * fix: display values with scientific notation --------- Co-authored-by: Jim Daniels Wasswa <104334373+jim-deriv@users.noreply.github.com>
* fix: translation files * fix: extract translations * chore: alphabetical order * chore: sync translation
…8920/ts-migration-parent
…88920/ts-migration-parent
Co-authored-by: Nijil Nirmal <62882794+nijil-deriv@users.noreply.github.com>
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
* fix: account switcher for mf * fix: undefined loginid * fix: add real account modal height * chore: removed unused props * chore: remove unused v2
…8920/ts-migration-parent
…88920/ts-migration-parent
| @@ -48,11 +52,11 @@ describe('<FileUploader />', () => { | |||
|
|
|||
| const file = new File(['hello'], 'hello.png', { type: 'image/png' }); | |||
|
|
|||
| const input = screen.getByTestId('dt_file_upload_input'); | |||
| const input = screen.getByTestId('dt_file_upload_input') as HTMLInputElement; | |||
There was a problem hiding this comment.
Suggestion:(Instead of of using 'as' can you give type to the variable directly)
| @@ -133,11 +137,11 @@ describe('<FileUploader />', () => { | |||
| const blob = new Blob(['sample_data']); | |||
| const file = new File([blob], 'hello.pdf', { type: 'application/pdf' }); | |||
|
|
|||
| const input = screen.getByTestId('dt_file_upload_input'); | |||
| const input = screen.getByTestId('dt_file_upload_input') as HTMLInputElement; | |||
yauheni-deriv
approved these changes
Feb 28, 2023
niloofar-deriv
force-pushed
the
niloo/88920/ts-migration-parent
branch
from
0fb8995
to
f3f9a44
Compare
sanjam-deriv
approved these changes
Feb 28, 2023
niloofar-deriv
merged commit d0ba145
into
niloofar-deriv:niloo/88920/ts-migration-parent
niloofar-deriv
pushed a commit
that referenced
this pull request
Jun 12, 2023
…-com#8270) * chore: add useTraderStores * chore: add trader-providers * refactor: replace MobxContentProvider with TraderProviders * chore: update trader to trade * refactor: replace connect in Trader package v1.0 (#76) * refactor: contract-replay, contract-drawer and contract-drawer-card to use useStore (#77) * Jim/93585/replace connect with usestore in market countdown timer market unavailable trade modals unsupported contract modal (#79) * refactor: remove connect from market-countdown-timer * refactor: remove connect from market-unavailable * refactor: remove connect from trade-modals * refactor: move is_visible prop to market-unavailable * refactor: remove connect from unsupported-contract-modal * Hamza/93474/replace connect with use trader store (#78) * refactor: replace connect in Trader package v1.0 * refactor: replace connect with useTraderStore v1.2 * refactor: replace connect with useTraderStore v1.2.1 * refactor: replace connect with useTraderStore v1.2.2 * refactor: replace connect with useTraderStore v1.2.3 * Hamza/93474/replace connect with use trader store (#80) * refactor: replace connect in Trader package v1.0 * refactor: replace connect with useTraderStore v1.2 * refactor: replace connect with useTraderStore v1.2.1 * refactor: replace connect with useTraderStore v1.2.2 * refactor: replace connect with useTraderStore v1.2.3 * refactor: replace connect with useTraderStore v1.3 * refactor: replace connect with useTraderStore v1.4 * Jim/93604/replace connect with use store in positions drawer positions modal card toggle positions mobile time picker populate header (#81) * refactor: remove connect from positions-drawer * refactor: remove connect from positions-modal-card * refactor: remove connect from toggle-positions-mobile * refactor: remove connect from time-picker * refactor: remove connect from populate-header * Jim/93667/replace connect with use store in trade header extensions trade settings extensions progress slider stream routes (#83) * refactor: remove connect from positions-drawer * refactor: remove connect from positions-modal-card * refactor: remove connect from toggle-positions-mobile * refactor: remove connect from time-picker * refactor: remove connect from populate-header * refactor: remove connect from trade-footer-extensions * refactor: migrate trade-header-extensions to ts and remove connect from it * refactor: migrate trade-settings-extensions to ts and remove connect from it * refactor: remove connect from progress-slider-stream and routes * chore: update mocstore with new fields * Hamza/93474/replace connect with use trader store (#82) * refactor: replace connect in Trader package v1.0 * refactor: replace connect with useTraderStore v1.2 * refactor: replace connect with useTraderStore v1.2.1 * refactor: replace connect with useTraderStore v1.2.2 * refactor: replace connect with useTraderStore v1.2.3 * refactor: replace connect with useTraderStore v1.3 * refactor: replace connect with useTraderStore v1.4 * refactor: replace connect with useTraderStore v1.5 * refactor: replace connect with useTraderStore v1.5.1 * refactor: replace connect with useTraderStore v1.5.2 * refactor: replace connect with useTraderStore v1.5.3 test failing fixed * refactor: replace connect with useTraderStore v1.5.4 * Jim/88556/replace connect with use store in settings chart accumulators stats contract replay widget contract and toolbar widgets (#84) * chore: removeconnectsettings-chart/accumulators-stats/contract-replay-widget/contracttoolbar-widgets * refactor: remove connect from accumulators-stats.spec * refactor: replace connect in top-widgets_cancel-deal-mobile_risk-management-info_mobile-widget * Hamza/93474/replace connect with use trader store (#85) * refactor: replace connect in Trader package v1.0 * refactor: replace connect with useTraderStore v1.2 * refactor: replace connect with useTraderStore v1.2.1 * refactor: replace connect with useTraderStore v1.2.2 * refactor: replace connect with useTraderStore v1.2.3 * refactor: replace connect with useTraderStore v1.3 * refactor: replace connect with useTraderStore v1.4 * refactor: replace connect with useTraderStore v1.5 * refactor: replace connect with useTraderStore v1.5.1 * refactor: replace connect with useTraderStore v1.5.2 * refactor: replace connect with useTraderStore v1.5.3 test failing fixed * refactor: replace connect with useTraderStore v1.5.4 * refactor: replace the connect with useStore v1.6 * fix: reverted the duration-wrapper * fix: the duration-wrapper * refactor: replace connect in top-widgets_cancel-deal-mobile_risk-management-info_mobile-widget (#86) * refactor: restore component structure to its original form * refactor: remove MobxContentProvider * refactor: replace connect in strike, vanilla-trade-type, screen-small, chart-widgets, and test * Jim/93866/replace_connect_with_usestore_in_strike_vanilla-trade-type_screen-small_chart-widgets_and_test (#87) * refactor: replace connect in top-widgets_cancel-deal-mobile_risk-management-info_mobile-widget * refactor: restore component structure to its original form * refactor: remove MobxContentProvider * refactor: replace connect in strike, vanilla-trade-type, screen-small, chart-widgets, and test * Hamza/93474/replace connect with use trader store (#88) * refactor: replace connect in Trader package v1.0 * refactor: replace connect with useTraderStore v1.2 * refactor: replace connect with useTraderStore v1.2.1 * refactor: replace connect with useTraderStore v1.2.2 * refactor: replace connect with useTraderStore v1.2.3 * refactor: replace connect with useTraderStore v1.3 * refactor: replace connect with useTraderStore v1.4 * refactor: replace connect with useTraderStore v1.5 * refactor: replace connect with useTraderStore v1.5.1 * refactor: replace connect with useTraderStore v1.5.2 * refactor: replace connect with useTraderStore v1.5.3 test failing fixed * refactor: replace connect with useTraderStore v1.5.4 * refactor: replace the connect with useStore v1.6 * fix: reverted the duration-wrapper * fix: the duration-wrapper * fix: contract not bought error config missing from props * refactor: remove connect function definition and connectwithcontractupdates * Jim/93908/remove-connect-and-connect-with-contract-updates-definitions from trader (#89) * refactor: replace connect in top-widgets_cancel-deal-mobile_risk-management-info_mobile-widget * refactor: restore component structure to its original form * refactor: remove MobxContentProvider * refactor: replace connect in strike, vanilla-trade-type, screen-small, chart-widgets, and test * refactor: remove connect function definition and connectwithcontractupdates * refactor: address whitespace comments, type exportsclear * chore: remove unused invalid import * chore: add type keyword on import statement * chore: add whitespace * refactor: remove passthrough.root_store * chore: restore props * chore: remove sonarcloud bug * refactor: wrap allowequalsmobile in a div to make it collapsible --------- Co-authored-by: Muhammad Hamza <120543468+hamza-deriv@users.noreply.github.com>
niloofar-deriv
pushed a commit
that referenced
this pull request
Aug 10, 2023
* feat: connect turbos contracts_for & take barrier_choices * chore: add barrier count to turbos config * chore: connected proposal API + added Stake header + updated purchase button (#75) * Kate/87485/add Turbos to the Trade types list (#74) * feat: add turbos to trade types * feat: add icon for description * refactor: separate trade types description, change svg and make info icons being visible for mob * fix: replace icons name to proper define * fix: correct spelling for turbos icon * Kate/87510/add existing Take Profit component to Turbos Trade params (#77) * refactor: add existing take profit component for turbos * refactor: unite condition for riskmanagmentinfo component for multiplier and turbos * fix: maryia/hide info from purchase button correctly * hamza/ feat: Barrier Line Colors depend upon the contract type (#80) * feat: Barrier Line Colors depend upon the contract type * chore: Reafctor Barrier Line Colors depend upon the contract type v1.2 * chore: Reafctor Barrier Line Colors depend upon the contract type v1.3 * hamza/dynamic Turbos purchase button with icons (#79) * feat: Dynamics Buttons Desktop + Responsive * chore: refactor the code * chore: refactor chnages v1.2 * chore: refactor css * chore: refactor css v1.3 * chore: removed the function and moved to helpers * chore: removed the function and moved to helpers v1.1 * chore: removed the function and moved to helpers renamed v1.2 * Kate/87536/add existing Duration & Amount(Stake) components to Turbos Trade params (#78) * feat: create turbos info componenet, based on existing multiplier component * refactor: add duration and stake for turbos mobile based on existing component * refactor: unite two similar text components in one function, correct spelling in store * refactor: remove fuction from component and make it pure, change px to rem in styles * refactor: turn function into component and clean up props values * refactor: add todo comment * hamza/88083/To Adjust the purchase button styles including animation (#83) * chore: style changes v1.0 * fix: styling animation * fix: button styling responsive * fix: button styling responsive v1.3 * Kate/87506/To implement Turbos Contract card in Recent Positions drawer and Contract Details (#82) * feat: add proper type name for turbos in recent positions * refactor: extend getcontracttypedisplay function, do decomposing * refactor: config files for recent positions card * feat: add recent position card for desktop and plug in min and max stake * feat: add card for recent positions for mobile * fix: delete extra properties * refactor: add react fragment and shrink arrow function * fix: spelling in trade type * feat: add turbos contract card for contract details page for desktop * feat: add turbos card for details page mobile * refactor: replace wrong contracts type to turbos * refactor: add nested styles, rename variables * refactor: shrink styles for contract card * fix: status timer style * refactor: cleared classname * fix: change px to rem * Hamza / 87508/feat:To add Turbos to Open Positions page [Desktop & Responsive] (#85) * feat: desktop view added in reports open positions * chore: desktop view tweaks v1.1 * chore: open positions v1.3 * chore: Mobile Css v1.4 * fix: mobile responsive v1.5 * chore: open positions turbos and multipliers v1.6 * chore: open positions turbos and multipliers commented code v1.7 * refactor: UI Changes as per Figma and refactor Css * fix: Recent Positions and refactor Css v1.8 * fix: Recent Positions and refactor Css v1.9 * fix: Recent Positions and refactor Css v1.10 * fix: Recent Positions and refactor Css v1.11 * Kate/87395/add turbos barriers component (#87) * feat: init barriers components file * feat: add BrriersTable component with base styles * refactor: config files, fix css for card details and add toggle func for new comp * feat: add state for condition of rendering barrierstable component, add animation * feat: implement function for setting new barrier value * feat: add new component for list and list-item, refactor css and store function * feat: add new observable and set func to the store for hover value, add scroll comp * refactor: rename barriers component, restructured it, change type of mouse events, delete utilit * refactor: exclude extra component renders * feat: add collapsed barriers * refactor: rename params and remove a helper function to a separate file * chore: empty commit to triger tests * refactor: incapsulate logic of event handlers inside barriers-list component, replace input comp * refactor: change the structure of header_tooltip_text * refactor: replace header_tooltip_text with Localize component * refactor: change the structure of event handlers * refactor: delete extra class for hover * refactor: delete event handler * Kate/87397/[Responsive]: To add Collapsed Turbos barriers in Trade params (#91) * feat: add barrier collapsed for mobile, refactor css for trade type info card * fix: forgot call function * refactor: change style of payout per point in mobile acc to design * Hamza/ 88943 /feat: add Long & Short Tabs to trade params for desktop (#90) * feat: trade params turbos desktop v1.0 * feat: trade params turbos desktop v1.1 * feat: trade params turbos desktop tabs working v1.2 * fix: turbos short long tabs * fix: turbos short long tabs v1.4 * fix: turbos short long tabs v1.5 * fix: turbos short long tabs v1.6 * fix: turbos short long tabs v1.7 * fix: turbos short long tabs v1.8 * fix: turbos short long v1.9 * fix: turbos short long v1.10 * Kate/87400/add Expanded view for Turbos Barriers opening in a MobileDialog to Trade params (#93) * feat: add barriers expanded version for mobile * refactor: disabled btn if the selected barrier is the same * refactor: change scss selector and cover tooltip into div * refactor: cover header mobile in order to simplify css style * refactor: delete state for button and chnge styles for dark mode * refactor: increase the usage of text component * refactor: replace the rest of the text by Text component * refactor: add ternal operator * refactor: change the structure of barrier list and replace li with text * refactor: unite trade type info description for turbos * refactor: delete extra brakets Co-authored-by: Maryia <103177211+maryia-deriv@users.noreply.github.com> --------- Co-authored-by: Maryia <103177211+maryia-deriv@users.noreply.github.com> * Hamza/89706/test cases of new features (#96) * feat: trade type tabs test case added * feat: trade type tabs test case added v1.2 * feat: trade type tabs test case added v1.2.1 * feat: trade type tabs test case added v1.3 * feat: trade type tabs test case added v1.4 * feat: trade type tabs test case added v1.4.1 * feat: trade type tabs test case added v1.5 * feat: trade type tabs test case added v1.5.1 * feat: trade type tabs test case added v1.6 * feat: trade type tabs test case added v1.7 * feat: trade type tabs test case added v1.8 * fix: component test fix * fix: jest mock function removed * fix: string literals * Hamza/87396/feat: responsive trade type tabs (#98) * feat: responsive trade type tabs v1.0 * feat: responsive trade type tabs v1.1 * feat: responsive trade type tabs v1.2 * feat: responsive trade type tabs v1.3 * feat: responsive trade type tabs v1.4 * refactor: tradetypetabs integration into barrier selector * refactor: tradetypetabs integration into barrier selector v1.2 * Apply suggestions from code review --------- Co-authored-by: Maryia <103177211+maryia-deriv@users.noreply.github.com> * Kate/89669/tests for turbos (#97) * refactor: add tests for new components * refactor: add tests for new components * chore: correct spelling * refactor: remove duplicated classnames into a sep constant * refactor: delete extra test-id, which were in the comp by default * refactor: remove has_stop_loss from mock_props * refactor: add has_stop_loss to mock_props * refactor: implemented suggestions * refactor: delete extra backticks * refactor: add more tests and delete extra property * fix: change style for turbos contract card (#100) * refactor: maryia/refactored TurbosInfo, tests & OpenPositions * Kate/90808/90829/ To migrate turbos-card-body, turbos-trade-description, barrier-selector and barrier-list to TS together with their tests (#102) * refactor: ts migration of new components for turbos with tests * refactor: migrate BarrierSelector to TS, update tests * refactor: translate TurbosCardBody to TS * refactor: translate TurbosCardBody tests * refactor: deal with ts errors in logic.ts * refactor: update packege json for trader by adding more test dependen * refactor: migrate turbos-card-body test to ts * refactor: delete extra pass of properties in test TurbosCardBody * refactor: migrate barrier-utils and add test * refactor: delete extra portals in test * refactor: delete extra type * refactor: translate tradeTypeTabs to ts with tests and apply recent design changes * Update packages/trader/src/Modules/Trading/Components/Form/TradeParams/Turbos/barrier-selector.tsx --------- Co-authored-by: Maryia <103177211+maryia-deriv@users.noreply.github.com> * Kate/90812/To migrate turbos-info and payout-per-point to TS together with their tests + add tests for payout-per-point (#104) * refactor: migrate to TS PayoutPerPoint and TurbosInfo with tests * Update packages/trader/src/Modules/Trading/Components/Elements/Turbos/payout-per-point.tsx * Apply suggestions from code review Co-authored-by: Matin shafiei <matin@binary.com> --------- Co-authored-by: Maryia <103177211+maryia-deriv@users.noreply.github.com> Co-authored-by: Matin shafiei <matin@binary.com> * refactor: update function for turbos cards filtration (#105) * chore: vanilla+turbos adjustment * chore: integrate turbos into options in open positions * chore: maryia/design adjustments * Kate/87523/Make barriers and payout per point collapsible in responsive (#106) * feat: make barriers and payout collapsible * refactor: change getTurbosSubtype function and add cards filtration for mobile * refactor: lift up the mobile chart for turbos * feat: add more details in tooltip * refactor: shrink getTurbosSubtype function * feat: update charts version * chore: add package lock file * fix: add flags for vanillas * Kate/91508/To finalize Payout per point component and its tooltip (#110) * refactor: expand getContractSubtype function * refactor: delete round for turbos payout per point * fix: change test case * refactor: replace base tags with text tag and add duration text function (#111) * Kate/91602/Display Long and Short open contracts in DTrader chart simultaneously (#112) * feat: show both long and short recent contracts on chart * refactor: add short and long options for barrier in store in order to display correct val * Apply suggestions from code review --------- Co-authored-by: Maryia <103177211+maryia-deriv@users.noreply.github.com> * refactor: maryia/rounding payout per point + refactoring * Kate/91815/Final checks and adjustments (#113) * refactor: delete decimals for payout per point in Turbos * refactor: minor changes and add arrow in payout per point * fix: add arrow for mobile payout per point turbos * refactor: add longcode as info in contract details for vanillas * chore: change btn name * refactor: reused MinMaxStakeInfo & PayoutPerPointMobile for vanillas and turbos + improvements * Kate/91999/Technical debt: To reuse Vanillas & Turbos common UI elements (#114) * refactor: apply trade type tabs to vanilla * refactor: apply barriers list for vanilla * refactor: remove bode list to a separate components * chore: small changes according to pr suggestions * fix: return undefind for amount and fieldset * Apply suggestions from code review --------- Co-authored-by: Maryia <103177211+maryia-deriv@users.noreply.github.com> * refactor: barriers-list and its body & trade-type-tabs * refactor: address review comments * refactor: address review comments * refactor: remove getTurbosDurationText * refactor: old getDurationUnitText to reduce cognitive complexity * fix: address review comments * fix: conditional rendering of total profit/loss * fix: replace time and add comment (#116) * Kate/refactor after last review (#117) * refactor: delete extra filed in object * refactor: add storeProvider and mockStore for tests * chore: optimise code size * fix: bug with contract info slider * fix: bug with contract info and refactor widget component * chore: rename constant for tests * refactor: add T prefix * chore: remove extra const * fix: filter turbos cards in responsive & reports popover text * refactor: address review comments * refactor: TurbosTradeDescription content * Merge branch master of github.com:binary-com/deriv-app into maryia/87354/task-add-turbos * chore: caching barrier choices and selected barrier for turbos * fix: add response check (#118) * Kate/92888/turbos content update (#119) * refactor: update content for contract type and payout per point * chore: update text in contract type info test * Kate/93137/Profit value is not displayed right in the contract details page (#120) * fix: add profit for turbos card after contract is sold * chore: update unit tests for turbos card body * chore: add optional chaining for response error check * chore: remove rounding for barrier in contract card * refactor: change formatting for barrier in turbos card * chore: add ternary operator for formating * chore: remove extra sign * refactor: make first barrier chosen by default * refactor: delete extra optional chaning * fix: bug with barriers in contract details (#121) * fix: maryia/93143/chart markers count in contract details + refactoring * revert: unnecessary change to chart markers count for turbos * Kate/93403/Payout per point is not displayed in contract detail page (#122) * feat: add payout per point for turbos contract details * fix: replace reg exp for turbos and vanillas * refactor: minor refactoring * revert: no longer needed changes in useStore.tsx * Kate/93332/CD: [Change Request] replace contract card fields by new ones (#123) * refactor: change turbos details * feat: add third row to contract card with new values and rewrite tests * refactor: make total profit loss always visible for turbos card * chore: rename classname * fix: change style for turbos mobile (#124) * Kate/Barrier text in the section is not aligned properly (#125) * fix: change aligment for turbos Vanillas and Accum fieldset titles * refactor: replace px by rem * build: fix types * fix: imports for new tsx files * refactor: replace old turbo icons (#126) * fix: types + localization + reverted Vanillas tooltip text changes * fix: add icon for turbos long * chore: update icon bundle * refactor: use number of contracts instead of shortcode * refactor: sonarcloud + tests * fix: conflicts + address review * refactor: as per reviews * fix: apply gradient style to all contracts (#132) * chore: improve types as per reviews * chore: address reviews * refactor: sonarcloud warnings * build: trigger build * refactor: rename number of contracts (#134) * Kate / Apply suggestions from last code review (#135) * refactor: delete duplicared file and add constants for turbos names * refactor: apply suggestions from review * fix: address review comments * test: fix tests * fix: types * fix: sonarcloud warnings * build: trigger checks * fix: remove barrier shade * fix: contract card values alignment * fix: missing colon after Barrier * chore: add vanilla header with timer to turbos contract card in mobile reports * fix: sonarcloud warning * chore: show full title only in open positions * build: trigger build * fix: types in open-positions * fix: address review comments about types * refactor: type * build: empty commit --------- Co-authored-by: kate-deriv <121025168+kate-deriv@users.noreply.github.com> Co-authored-by: Muhammad Hamza <120543468+hamza-deriv@users.noreply.github.com> Co-authored-by: Matin shafiei <matin@binary.com> Co-authored-by: kate-deriv <kate@regentmarkets.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Please include a summary of the change and which issue is fixed below:
When you need to add unit test
When you need to add integration test
Test coverage checklist (for reviewer)
Type of change