Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix items tasks error #4498

Merged

Conversation

corentin-soriano
Copy link
Contributor

@corentin-soriano corentin-soriano commented Nov 27, 2024

The scheduler is stuck on tasks that handle sharekeys creation:

  • Fix SQL query:
#0 /var/www/teampass/vendor/sergeytsalkov/meekrodb/db.class.php(890): MeekroDB->queryHelper(Array, Array)
#1 /var/www/teampass/vendor/sergeytsalkov/meekrodb/db.class.php(116): MeekroDB->query('SELECT id, publ...', Array)
#2 /var/www/teampass/sources/main.functions.php(2640): DB::__callStatic('query', Array)
  • Improve task recursion to avoid high CPU load.
  • Error on item creation with empty password since Code review fixes #4412 (if ($encrypted === false) { -> if (empty($encrypted)) {).
  • Error on tasks page (missing field arguments in SQL query).

Copy link
Owner

@nilsteampassnet nilsteampassnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reaaly nice 👍

@nilsteampassnet nilsteampassnet merged commit 81f6b7e into nilsteampassnet:master Nov 27, 2024
1 check passed
@corentin-soriano corentin-soriano deleted the fix_items_tasks_error branch November 28, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants