Accessibility fixes and enhancements to the main window #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The window buttons are described sufficiently by their subrole (i.e. "zoom button"). The window is described sufficiently and properly by its AXTitle (which is name of the movie). Providing a non-empty AXDescription does not make sense and replaces the name of the movie in window title (notable e.g. with VO-F2).
Accessibility of NSControl is handled by its cell, the NSControl is itself hidden from accessibility.
This is available only on 10.7+, so the code needs to be guarded appropriately (#ifdefs, weak symbol nil check).
|
Thank you Dusek. It will take a while to review the commits. |
|
No problem :-) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.