fixes #10807 #10814
Merged
fixes #10807 #10814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Araq
reviewed
Mar 10, 2019
compiler/transf.nim
Outdated
| @@ -762,6 +762,10 @@ proc transformCall(c: PTransf, n: PNode): PTransNode = | |||
| inc(j) | |||
| add(result, a.PTransNode) | |||
| if len(result) == 2: result = result[1] | |||
| elif magic == mAddr: | |||
| result = newTransNode(nkHiddenAddr, n, 1) | |||
There was a problem hiding this comment.
Huh, how do you know it's nkHiddenAddr here?
There was a problem hiding this comment.
it is rather random choice, it can be nkAddr if you like. I thought it is good idea to remove nkAddr node in future and leave only call to mAddr magic instead.
There was a problem hiding this comment.
Ah I see. But please make it an nkAddr then.
|
should review for review once tests complete |
c-blake
pushed a commit
to c-blake/cligen
that referenced
this pull request
Mar 13, 2019
nim-lang/Nim#10807 changes received tree from nkAddr(subDocsId) to nkCall(addr(subDocsId)). Accept either old or new tree.
ringabout
added a commit
that referenced
this pull request
Apr 5, 2024
github-merge-queue bot
pushed a commit
to nim-works/nimskull
that referenced
this pull request
Oct 18, 2024
## Summary In typed AST, address-of operations are now *always* represented by `nkAddr` trees. This simplifies some compiler logic, makes processing for typed macros easier, and fixes an effect tracking bug with `addr`. ## Details This is effectively a revert of nim-lang/Nim#10814. Not turning calls to `mAddr` into `nkAddr` was done to prevent the unsafe address semantics from being lost, but those no longer exist. Lowering the call into an `nkAddr` tree has the benefit that it simplifies AST analysis and processing, as address-of operation can now always be detected by `PNode.kind == nkAddr`. Old code for detecting `mAddr` magic calls is removed. The effect tracking in `sempass2` had no special case for `mAddr` calls, thus treating them as normal calls, which led to `addr(x)` being treated as an indirect invocation of `x`, when `x` is of procedural type. With the `mAddr` call now being lowered earlier, this is no longer the case.
github-merge-queue bot
pushed a commit
to nim-works/nimskull
that referenced
this pull request
Oct 19, 2024
## Summary In typed AST, address-of operations are now *always* represented by `nkAddr` trees. This simplifies some compiler logic, makes processing for typed macros easier, and fixes an effect tracking bug with `addr`. ## Details This is effectively a revert of nim-lang/Nim#10814. Not turning calls to `mAddr` into `nkAddr` was done to prevent the unsafe address semantics from being lost, but those no longer exist. Lowering the call into an `nkAddr` tree has the benefit that it simplifies AST analysis and processing, as address-of operation can now always be detected by `PNode.kind == nkAddr`. Old code for detecting `mAddr` magic calls is removed. The effect tracking in `sempass2` had no special case for `mAddr` calls, thus treating them as normal calls, which led to `addr(x)` being treated as an indirect invocation of `x`, when `x` is of procedural type. With the `mAddr` call now being lowered earlier, this is no longer the case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
magic call to
mAddris now preserved till transformation stage where it is rewritten intonkHiddenAddr.It is now possible to delete
nkAddrnode kind completely, let me know if you are interested in this kind of breaking change.