Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#12103 - CI for FreeBSD #12179

Merged
merged 17 commits into from
Nov 29, 2019
Merged

Conversation

euantorano
Copy link
Contributor

@euantorano euantorano commented Sep 11, 2019

Fixes #12113
Fixes #12103

Linked to #12105 - this adds FreeBSD CI support where the other adds OpenBSD.

There are a few tests currently failing on FreeBSD. I've opened some issues for some of them and will open more after the current test run completes.

@euantorano
Copy link
Contributor Author

This PR is complete, the build fails due to other FreeBSD errors that I've opened issues for.

@euantorano
Copy link
Contributor Author

This seems to be hanging at PASS: tests/dll/client.nim C --gc:boehm --threads:on ( 0.43747401 secs) every time. I'm not sure which test should be running after that that's hanging though...

I've tested it locally on FreeBSD 12 RELEASE and it runs through all the tests without a problem, so I'm not sure what's going on.

@narimiran
Copy link
Member

How can we see what is failing? For you openBSD PR there are errors printed at the end of the log, but I don't see the same here.

@euantorano
Copy link
Contributor Author

@narimiran What's failing here is a timeout (see my previous comment), which I can't replicate on VMs or physical hardware. I'll push an empty commit to this PR later to try trigger another test run and see if it still times out.

@narimiran
Copy link
Member

narimiran commented Nov 11, 2019

I'll push an empty commit to this PR later

Even better: you can rebase it onto the latest devel and solve the existing merge conflict :)

@euantorano
Copy link
Contributor Author

@narimiran Sure, that should be easy enough. Will do so after work.

@euantorano
Copy link
Contributor Author

Looks like it's still stalling at the same point - it reaches PASS: tests/dll/client.nim C --gc:boehm --threads:on and then gets stuck...

I have no idea why, or what it's actually meant to be doing at that point.

@narimiran
Copy link
Member

Could you disable that test so we can see if something else fails too?

The top of tests/dll/client.nim should read:

discard """
  disabled: true
  output: "Done"
  cmd: "nim $target --debuginfo --hints:on --define:useNimRtl $options $file"
"""

@euantorano
Copy link
Contributor Author

euantorano commented Nov 12, 2019 via email

@euantorano
Copy link
Contributor Author

So I disabled tests/dll/client.nim and it now logs the following:

SKIP: tests/dll/client.nim C --gc:boehm --threads:on

It now seems to be stuck again, so whichever test is running after this one seems to be the problem.

lib/pure/os.nim Show resolved Hide resolved
@euantorano
Copy link
Contributor Author

Oh wow, the CI actually passed! 😮

@euantorano
Copy link
Contributor Author

Build failures seem unrelated as far as I can see - the current devel branch is failing too.

@Araq Araq merged commit c5c6bae into nim-lang:devel Nov 29, 2019
alehander92 pushed a commit to alehander92/Nim that referenced this pull request Dec 2, 2019
* Ref nim-lang#12103 - adds FreeBSD CI
* Fix getApplFreebsd - length of the string includes the null terminator byte, so minus 1 for result length
* Show last commit in setup task.
* Remove .git from repository URL
* Don't include noisy details showing last commit.
* Add FreeBSD build status badge
* Fix nim-lang#12182 - disable tconsole on FreeBSD
* Disable tgetaddrinfo on FreebSD as getaddrinfo doesn't support the ICMP protocol.
* Install boehm-gc-threaded
* Use libgc-threaded.so on FreeBSD rather than libgc.so.
* Simplify build failure handling. Update alt text for CI badge.
* Disable test on FreeBSD
* Simplify build config

- use GNU make to build csources
- set PATH variable using the environment key
- remove modification of config to set CC as this is already set

* Install git which seems to be missing from current freebsd images
* Revert change to how path is set
* Add a comment explaining why the length is truncated
* Fix tconsole.
@euantorano euantorano deleted the feature/12103-freebsd-ci branch March 22, 2020 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Koch bootCI error on FreeBSD CI for FreeBSD and OpenBSD
4 participants