New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make the docs of arithmetics better #16510

Merged

Araq merged 5 commits into nim-lang:devel from ringabout:4

Dec 30, 2020

Member

ringabout commented Dec 30, 2020 •

edited

Loading

Ref timotheecour#415

code-blocks => runnableExamples
double backticks => single backticks

ringabout force-pushed the 4 branch from a78c955 to bf58aff Compare

December 30, 2020 04:05

Member Author

ringabout commented Dec 30, 2020

proc + noSideEffect => func makes {.borrow.} wrong

ringabout force-pushed the 4 branch from bf58aff to fa52c4b Compare

December 30, 2020 04:16

ringabout added 2 commits

December 30, 2020 12:17

fix

fa52c4b


          Merge remote-tracking branch 'upstream/devel' into 4

430e79b

timotheecour reviewed

View reviewed changes

lib/system/arithmetics.nim Outdated Show resolved Hide resolved


          Update lib/system/arithmetics.nim

4c240ea

Co-authored-by: Timothee Cour <timothee.cour2@gmail.com>

timotheecour reviewed

View reviewed changes

lib/system/arithmetics.nim Outdated Show resolved Hide resolved

timotheecour reviewed

View reviewed changes

lib/system/arithmetics.nim Outdated Show resolved Hide resolved


          Apply suggestions from code review

5da68e9

Co-authored-by: Timothee Cour <timothee.cour2@gmail.com>

timotheecour reviewed

View reviewed changes

lib/system/arithmetics.nim Outdated Show resolved Hide resolved

timotheecour reviewed

View reviewed changes

lib/system/arithmetics.nim Outdated Show resolved Hide resolved

timotheecour reviewed

View reviewed changes

lib/system/arithmetics.nim Outdated Show resolved Hide resolved


          Apply suggestions from code review

c7ffdf3

Co-authored-by: Timothee Cour <timothee.cour2@gmail.com>

timotheecour approved these changes

View reviewed changes

Araq merged commit b42e7c0 into nim-lang:devel

mildred pushed a commit to mildred/Nim that referenced this pull request


          make the docs of arithmetics better (nim-lang#16510)

0e4599b

* fix

* Update lib/system/arithmetics.nim

Co-authored-by: Timothee Cour <timothee.cour2@gmail.com>

* Apply suggestions from code review

Co-authored-by: Timothee Cour <timothee.cour2@gmail.com>

* Apply suggestions from code review

Co-authored-by: Timothee Cour <timothee.cour2@gmail.com>

Co-authored-by: Timothee Cour <timothee.cour2@gmail.com>

ringabout mentioned this pull request

using func keyword instead of proc in standard libraries #16832

Open

ardek66 pushed a commit to ardek66/Nim that referenced this pull request


          make the docs of arithmetics better (nim-lang#16510)

c2bc468

* fix

* Update lib/system/arithmetics.nim

Co-authored-by: Timothee Cour <timothee.cour2@gmail.com>

* Apply suggestions from code review

Co-authored-by: Timothee Cour <timothee.cour2@gmail.com>

* Apply suggestions from code review

Co-authored-by: Timothee Cour <timothee.cour2@gmail.com>

Co-authored-by: Timothee Cour <timothee.cour2@gmail.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet