[vm]fixes #15974 #12551 #19464 #16020 #16780 #16613 #14553 #19909 #18641 #19902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ringabout
changed the title
ringabout
changed the title
ringabout
changed the title
ringabout
changed the title
ringabout
changed the title
ringabout
changed the title
ringabout
commented
Jun 16, 2022
compiler/vm.nim
Outdated
| @@ -1028,9 +1027,9 @@ proc rawExecute(c: PCtx, start: int, tos: PStackFrame): TFullReg = | |||
| if regs[rc].kind == rkNodeAddr: | |||
| ret = regs[rb].nodeAddr == regs[rc].nodeAddr | |||
| else: | |||
| ret = ptrEquality(regs[rb].nodeAddr, regs[rc].node) | |||
| ret = ptrEquality(regs[rb].nodeAddr, regs[rc].regToNode) # todo fixme | |||
There was a problem hiding this comment.
It seems to be a pre-existing issue:
type
SinglyLinkedList[T] = ref object
proc addMoved[T](a, b: var SinglyLinkedList[T]) =
if a.addr != b.addr: discard
proc main =
var a: SinglyLinkedList[int]; new a
var b: SinglyLinkedList[int]; new b
a.addMoved b
static: main()gives the same error messages as objects(my PR - regToNode) => field 'node' is not accessible for type 'TFullReg' using 'kind = rkRegisterAddr' [FieldDefect] with 1.6.6 for ref objects.
My PR re-exposes the scar hidden for objects. I'm gonna to fix this pre-existing issue.
There was a problem hiding this comment.
fixed on the latest commit
|
Ping me again when it's ready. |
ringabout
changed the title
ringabout
changed the title
|
@narimiran could this be backported (preferrably 1.6 and 1.4)? This would allow to fix a bug in https://github.com/nim-lang/bigints for more than just devel (see nim-lang/bigints#94). |
It is already backported to the 1.6, which is our LTS, and it will be part of our next 1.6 release. The 1.4 line is not really maintained anymore, i.e. don't expect any new releases. |
narimiran
added a commit
that referenced
this pull request
Jul 18, 2022
capocasa
pushed a commit
to capocasa/Nim
that referenced
this pull request
Mar 31, 2023
…im-lang#16780 nim-lang#16613 nim-lang#14553 nim-lang#19909 nim-lang#18641 (nim-lang#19902) [backport] * revert nim-lang#12217 since the root problem seems to have been fixed; fix nim-lang#15974;fix nim-lang#12551; fix nim-lang#19464 * fix nim-lang#16020; fix nim-lang#16780 * fix tests and nim-lang#16613 * fix nim-lang#14553 * fix nim-lang#19909; skip skipRegisterAddr * fix nim-lang#18641
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #12217 since the root problem seems to have been fixed;
The tests (see tests/vm/tmisc_vm.nim) fixed by #12217 continues to work after reverting the pr.
fixes #15974 regression(0.20.0 => devel): var params assignment gives silently wrong results in VM
fixes #12551 [regression] var param corruption and variable mutation when run the code with VM
fixes #19464 [VM] Immutable proc argument is incorrectly modified
fixes #16020 addr(object) doesn't work in VM
fixes #16780 object copy broken in vm
fixes #16613 Nim crashes randomly
fixes #14553 GC crash in VM with tuple unpacking loop and table
fixes #19909 addressing ref objects and comparing the pointer address in vm give FieldDefect
fixes #18641 addr doesn't work inside static at proc scope