Devel #46
Merged
Devel #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Clonkk
commented
May 10, 2024
•
Clonkk
commented
- Add API to log or echo EAGAIN error
- Add -d:defaultFlagDontWait to change the default flag to receive / send proc to DONTWAIT instead of NOFLAGS
- Add docstring about using non-blocking in asyncPoll context
- Modified examples and test to use non-blocking function in asyncPoll
- This shouldn't change anything for asyncReceive / asyncSend
…to display errno behind a define; start work on overriding default send / receive flags with NOWAIT in async context
Araq
reviewed
May 11, 2024
| ### Log EAGAIN errno | ||
|
|
||
| Sometimes EAGAIN error happens in ZMQ context; typically this is a non-ctritical error that can be ignored. Nonetheless, if you desire to logg or display such error you can compile with the flag ``-d:zmqEAGAIN`` and EAGAIN error will be logged using ``std/logging`` or ``echo`` to stdout if no logger handler is defined. | ||
|
|
There was a problem hiding this comment.
How hard would it be to make this a runtime switch? Compile-time switches for libraries do not compose.
There was a problem hiding this comment.
Very easy.
I will make the change.
|
ping @Araq anything else for this PR ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.