-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new channels article #274
new channels article #274
Conversation
Co-authored-by: Timothee Cour <timothee.cour2@gmail.com>
@ee7 can you proof-read please? :P |
joinThreads(sender) | ||
for i in 0 .. receiver.high: | ||
createThread(receiver[i], recvHandler) | ||
let start = now() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: konsumlamm <44230978+konsumlamm@users.noreply.github.com>
Co-authored-by: konsumlamm <44230978+konsumlamm@users.noreply.github.com>
Co-authored-by: konsumlamm <44230978+konsumlamm@users.noreply.github.com>
Co-authored-by: konsumlamm <44230978+konsumlamm@users.noreply.github.com>
Co-authored-by: konsumlamm <44230978+konsumlamm@users.noreply.github.com>
Co-authored-by: Zoom <ZoomRmc@users.noreply.github.com>
I see that @narimiran changed the date - does that mean this is going to be posted soon? This article currently advertises "safe to use" quite a lot. But did we fix enough bugs in |
Why even say this? It implies that it has a reputation as not being safe to use. Just omit this wording completely, the assumption is that libraries are safe to use when they are being advertised as "ready for use". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
All the examples in the article use globals for channels, what's worse, the only example in the module docs does the same. I understand it's the simplest way, but shouldn't we say a couple of words on how to properly use them without global variables?
-
Is the article planned to be released when channels gets out of devel? Will the old one get deprecated simultaneously? In any case, there should be an explicit mention on how to adapt the code which uses
system.Channel
to the new one, even if it's mereJust remove X,Y and Z and you're done!
Since the channel module may be rewritten/redesigned, this article will become a bit irrelevant. So I mark it as a draft. |
Yes, I am in process of re-writing the module as the old one has a lot of problems including one or two data races. It's almost finished. When it has been accepted, I'll revisit this to see if this document reflects what the actual module has become. |
No description provided.