replace with newSym

nim-works · Sep 28, 2023 · 9d258d7 · 9d258d7
1 parent 35b4d59
commit 9d258d7
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 6 deletions.
diff --git a/compiler/ast/ast.nim b/compiler/ast/ast.nim
@@ -516,9 +516,6 @@ template transitionSymKindCommon*(k: TSymKind) =
   when defined(nimsuggest):
     s.allUsages = obj.allUsages
 
-proc transitionSymKindCommon*(s: PSym, kind: TSymKind) =
-  transitionSymKindCommon(kind)
-
 proc transitionGenericParamToType*(s: PSym) =
   transitionSymKindCommon(skType)
 

diff --git a/compiler/sem/sem.nim b/compiler/sem/sem.nim
@@ -431,9 +431,7 @@ proc newSymGNode*(kind: TSymKind, n: PNode, c: PContext): PNode =
         n.sym.owner = currOwner # xxx: modifying the sym owner is suss
         n
       else:
-        let recoverySym = copySym(n.sym, nextSymId c.idgen)
-        recoverySym.transitionSymKindCommon(kind)
-        recoverySym.owner = currOwner
+        let recoverySym = newSym(kind, n.sym.name, nextSymId c.idgen, currOwner, info)
         c.config.makeError(n, recoverySym, ExpectedKindMismatch)
   of nkIdent, nkAccQuoted:
     # xxx: sym choices qualify here, but shouldn't those be errors in