This is the second commit of an ongoing effort to remove cruft from t…

…he test suite,

and remove the 'disabled' keyword from the testament spec.

In the first commit, we added the new knownIssue key to the testament spec,
while also adding knownIssues to many of the tests for which we could attribute an issue.

In this commit, we almost finish the task of removing the 'disabled' keyword
from the remaining tests.

Below are the changes and reasonings behind them:

Removed Due to old or removed features:

    tdatabind.nim
    texplicit_dummy_closure.nim
    tgenconstraints.nim
    tincludefile.nim
    tmodulealias.nim
    tno_gcmem_in_shared.nim
    tnotuniquename2.nim
    tscheduler.nim

Removed due to being Half Baked or Non-sensical:

    tio.nim
    tmissingnilcheck.nim
    treadafterwrite.nim
    trecmod.nim
    tunsignedcomp.nim

Removed due to not being worth the trouble:

    t5000.nim

Removed due to being redundant:

    tisop.nim

Keeping disabled, due to being unsure:

    t7894.nim - Works, but flaky, and makes CI servers grumpy.
    tdllvar.nim
    tpragmas_misc.nim

Added knownIssues - Mostly textual descriptions, due to not having a explicit issues:

    tdont_init_instantiation.nim
    titerable.nim
    toutparam.nim
    toverload_asgn2.nim
    tparsopt.nim

Re-enabled:

    tglobal.nim
    tmultim.nim
    tmultimjs.nim
    tobjpragma.nim
    toverloading_typedesc.nim

Fixed

    trectuple.nim: Fixed the line number.
    trectype.nim : Fixed to the spec.

tests/assign/toverload_asgn2.nim

@@ -1,7 +1,7 @@
 discard """
   output: '''i value 88
 2aa'''
-  disabled: "true"
+    knownIssue: "possible issue where result is not treated as var Concrete in passAround"
 """
 
 import moverload_asgn2

tests/cpp/tdont_init_instantiation.nim

@@ -1,7 +1,7 @@
 discard """
   targets: "cpp"
   output: ''''''
-  disabled: true
+    knownIssue: "https://github.com/nim-lang/Nim/issues/5140"
 """
 
 # bug #5140

tests/effects/toutparam.nim

@@ -2,7 +2,7 @@ discard """
   cmd: '''nim c --warningAsError:Uninit:on --skipCfg --skipParentCfg $file'''
   errormsg: "use explicit initialization of 'x' for clarity [Uninit]"
   line: 24
-  disabled: "true"
+    knownIssue: "parameter name is being clobbered "
 """
 
 proc gah[T](x: out T) =

tests/generics/toverloading_typedesc.nim

@@ -1,6 +1,6 @@
 discard """
   exitcode: 0
-  disabled: '''true'''
+
 """
 import moverloading_typedesc
 import tables

tests/global/tglobal.nim

@@ -1,6 +1,6 @@
 discard """
   output: "in globalaux2: 10\ntotal globals: 2\nint value: 100\nstring value: second"
-  disabled: "true"
+
 """
 
 import globalaux, globalaux2

tests/iter/titerable.nim

@@ -6,7 +6,7 @@ discard """
 8
 12
 '''
-  disabled: "true"
+    knownIssue: "lambda lifting support for iterToProc plugin; lambda lifting and iterators are likley to go through a bit spec definition and this will either get folded in and its a good signal to know whether we fixed something by happenstance or not."
 """
 
 # Will eventually fix it...

tests/method/tmultim.nim

@@ -10,7 +10,7 @@ collide: thing, unit |
 do nothing
 '''
   joinable: false
-  disabled: true
+
 """
 
 

tests/method/tmultimjs.nim

@@ -4,7 +4,7 @@ discard """
 Hi derived!
 hello
 '''
-  disabled: true
+
 """
 
 

tests/misc/tdllvar.nim

@@ -1,5 +1,5 @@
 discard """
-disabled: true
+    disabled: true
 """
 
 import os