cgir: remove the legacy CGIR variant #1234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are the node kinds only produced by the legacy version of `cgirgen`.
zerbina
added
compiler/backend
saem
approved these changes
Mar 12, 2024
|
/merge |
|
Merge requested by: @saem Contents after the first section break of the PR description has been removed and preserved below:
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Hm, strange. The compiler crashed during the leak test (but only during the second attempt at merging). I don't see how the changes here could have caused that, so I'll give merging another go. |
alaviss
pushed a commit
to nim-works/nimskull-test-bed
that referenced
this pull request
Jul 5, 2024
## Summary Clean up the category and enable it for all targets by default. This significantly increases test coverage of exceptions for the JS and VM targets. ## Details **General changes/cleanup:** * references to issues like `nim-works#1234` are replaced with proper GitHub links * the `targets` key is removed for tests that should be run on all targets * usage of `cmd` is replaced with usage of `matrix` (allowing for multi-target testing) * `write(stdout, ...)` is replaced with `echo` in order to support the JS and VM targets * execution of `static:` blocks is replaced with using the VM target, when the test is not specific to compile-time execution * tests that don't work but should are marked as `knownIssue` **Specific changes:** * where not necessary for the test, `getCurrentExceptionMsg` is replaced with `getCurrentException().msg`, as the former is not yet supported by the VM * `texceptions2.nim` is removed -- it's redundant with `texception.nim` * `texception_message_null_byte.nim` is turned into a normal test that doesn't rely on self-execution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
All code generators use the new goto-using variant of the CGIR now,
rendering the legacy variant obsolete. This is an internal-only
refactoring.
Details
cgirgen_legacymodulecnkStmtListExpr(they were dead codealready)