Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate the .codegenDecl pragma #1358

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

zerbina
Copy link
Collaborator

@zerbina zerbina commented Jun 26, 2024

Summary

The .codegenDecl pragma is going to be removed eventually. For a
transition period, a deprecation warning is now reported when using it.

Summary
=======

The `.codegenDecl` pragma is going to be removed eventually. For a
transition period, a deprecation warning is now reported when using it.
@zerbina zerbina added compiler/sem Related to semantic-analysis system of the compiler compiler/backend Related to backend system of the compiler labels Jun 26, 2024
@zerbina zerbina added this to the JS backend refactoring milestone Jun 26, 2024
@zerbina
Copy link
Collaborator Author

zerbina commented Jun 26, 2024

The earliest the built-in .codegenDecl pragma can be removed is when the asyncjs module is reworked to not depend on it. At most, the pragma can stay around until the new JavaScript code generator is implemented, which I'd currently estimate as being around 3 to 4 months away.

@saem
Copy link
Collaborator

saem commented Jun 26, 2024

/merge

Copy link

Merge requested by: @saem

Contents after the first section break of the PR description has been removed and preserved below:


Notes for Reviewers

  • a minor preparation for redoing the JavaScript code generator

@chore-runner chore-runner bot added this pull request to the merge queue Jun 26, 2024
Merged via the queue into nim-works:devel with commit e0ad8b1 Jun 26, 2024
31 checks passed
@zerbina zerbina deleted the deprecate-codegenDecl-pragma branch June 26, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler/backend Related to backend system of the compiler compiler/sem Related to semantic-analysis system of the compiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants