Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: split docs deployment from publisher and deploy directly to pages #1370

Merged
merged 3 commits into from
Jul 5, 2024

Conversation

alaviss
Copy link
Contributor

@alaviss alaviss commented Jul 4, 2024

Summary

Documentation will now be built using a separated workflow that will be
run whenever publisher finishes. This allows us to use the latest page
deployment code regardless of the commit that triggered publisher.

Details

  • Added get sub-command to release_manifest , which allows one to
    extract binary archive name from a release manifest.
  • "Generated docs" artifacts are now removed. Instead the generated
    documentation will be obtained from the release tarball for Linux amd64.
    This allows docs publishing to run regardless of whether the artifact
    for the latest release has expired or not.
  • Documentation deployment will now skip gh-pages branch and deploy
    directly using actions/deploy-pages . This allows us to drop the
    heavyweight gh-pages branch and remove the latency between push and
    page being deployed.
  • Documentation deployment can now be triggered on-demand in case of a
    prior failure.
  • Documentation deployment will now always be done using latest code in
    devel .
  • Development documentation is also pushed to /devel sub-folder.
    This is preliminary setup for versioned docs in the future.

Add a new `get` subcommand for querying the file name of the release
binary for a given target triplet. This will be used for obtaining
generated docs.
Documentation will now be built using a separated workflow that will be
run whenever publisher finishes. This allows us to use the latest
page deployment code regardless of the commit that triggered publisher.

Some auxilliary changes also come along:

- New deploy-docs workflow can also be run manually.
- "Generated docs" artifacts are now removed. Instead the generated
  documentation will be obtained from the release tarball for Linux.
  This is done since artifacts have a timeout to them, which meddle with
  our ability to run docs deployment at will.
- Implemented basic version segmentation: `/devel` subdirectory will now
  contain the latest devel docs.
@alaviss alaviss marked this pull request as ready for review July 4, 2024 16:24
@alaviss alaviss requested a review from a team as a code owner July 4, 2024 16:24
@saem saem added documentation Improvements or additions to documentation ci Continuous Integration labels Jul 5, 2024
Copy link
Collaborator

@saem saem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple typos in the docs you might want to look at, otherwise good.

doc/ci.rst Outdated Show resolved Hide resolved
Co-authored-by: Saem Ghani <saemghani+github@gmail.com>
@alaviss
Copy link
Contributor Author

alaviss commented Jul 5, 2024

/merge

Here we go

Copy link

github-actions bot commented Jul 5, 2024

Merge requested by: @alaviss

Contents after the first section break of the PR description has been removed and preserved below:


Notes for Reviewers

  • Confirmed working here
  • This is a part of the release pipeline development, being upstreamed first since it has immediate benefits of allowing for removal of gh-pages branch which is the heaviest branch in the repository.
  • CI docs are not updated yet, and will be soon ™️ Done.
  • Once merged, the repository's pages settings should be changed to "Publish via Actions"

@chore-runner chore-runner bot enabled auto-merge July 5, 2024 01:39
@chore-runner chore-runner bot added this pull request to the merge queue Jul 5, 2024
Merged via the queue into nim-works:devel with commit bd3d3dc Jul 5, 2024
31 checks passed
@alaviss alaviss deleted the push-pqqwpmqrppps branch July 5, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants