-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sem, pragmas: fix fatal pragma #1386
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very clean and concise fix. Thank you!
There are two small things that need adjustment, but otherwise this looks good.
Also, please make sure the PR message follows the guidelines. The first line works well as the summary; the details section should describe what changed internally (i.e., |
…ing since it has a very different purpose now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from isFatalSeverity
(refer to the comment I left regarding it), this PR is good to be merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from my side, thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
Merge requested by: @zerbina Contents after the first section break of the PR description has been removed and preserved below: |
Summary
Using
{.fatal:"...".}
did not show any message to the user and itdidn't stop compilation.
This commit fixes both issues.
Details
adSemFatalError
now carries a message just likeadSemCustomUserError
.fatal
severity abort compilation.isCompilerFatal
has been removed as it seems it lost its purpose.The check for
rextCmdRequiresFile
seems to be unnecessary. A fatalreport is produced elsewhere (the only place where
rextCmdRequiresFile
is used) before this function is ever called, soit was redundant and it doesn't break existing code.