fix missing destruction when discarding complex expression #1422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary ======= Fix the result of `if`, `case`, `block`, and `try` expression not being destroyed when `discard`ing the expression. Details ======= * in `mirgen`, a value-like PMIR expression is now requested for the discarded expression * `toValue` expects a properly value-like PMIR expression, which a complex expression, hence the missing destructor * the expression is now properly materialized, which means that the a destructor call is registered for the temporary
zerbina
added
bug
I think the bullet point is incomplete, did you mean: "which a complex expression didn't produce,"? |
saem
approved these changes
Aug 18, 2024
Ah, thank you, good catch. I meant that a complex expression is not a value-like expression (in this context) -- it's corrected now. |
|
/merge |
|
Merge requested by: @saem Contents after the first section break of the PR description has been removed and preserved below: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix the result of
if,case,block, andtryexpression not beingdestroyed when
discarding the expression.Fixes #1421.
Details
mirgen, a value-like PMIR expression is now requested for thediscarded expression
toValueexpects a properly value-like PMIR expression, which acomplex expression is not, hence the missing destructor
destructor call is registered for the temporary