Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sem): errors in lambdas no longer crash #1437

Merged

Commits on Aug 28, 2024

  1. fix(sem): errors in lambdas no longer crash

    Summary
    ---------
    
    Errors in lambdas requiring inference (`proc(e: auto) echo e`), no
    longer crash the compiler. Instead errors within the lambda body are
    reported and lambda inference fails as it should.
    
    Details
    -------
    
    `semInferredLambda` failed to wrap its output when there were errors.
    This would reach `transf` and result in a compiler crash by hitting an
    `unreachable` assertion.
    
    Now errors in the body are reported immediately (to provide context for
    inference failure) and AST output from the inference attempt is
    correctly wrapped such that inference appropriately fails.
    saem committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    0ddf173 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2024

  1. Update tests/lang_callable/generics/tauto_inference_failure_due_to_bo…

    …dy_error.nim
    
    Co-authored-by: zerbina <100542850+zerbina@users.noreply.github.com>
    saem and zerbina authored Aug 29, 2024
    Configuration menu
    Copy the full SHA
    85e1410 View commit details
    Browse the repository at this point in the history
  2. Update tests/lang_callable/generics/tauto_inference_failure_due_to_bo…

    …dy_error.nim
    
    Co-authored-by: zerbina <100542850+zerbina@users.noreply.github.com>
    saem and zerbina authored Aug 29, 2024
    Configuration menu
    Copy the full SHA
    831fdf7 View commit details
    Browse the repository at this point in the history
  3. Update compiler/sem/semstmts.nim

    Co-authored-by: zerbina <100542850+zerbina@users.noreply.github.com>
    saem and zerbina authored Aug 29, 2024
    Configuration menu
    Copy the full SHA
    dfe5eb8 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2024

  1. Configuration menu
    Copy the full SHA
    ad62b7f View commit details
    Browse the repository at this point in the history
  2. fix doc typo

    saem committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    6cbea54 View commit details
    Browse the repository at this point in the history
  3. revert doc change

    saem committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    640bb08 View commit details
    Browse the repository at this point in the history