Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sem): fix crash routine pragma redefinition #1445

Merged
merged 3 commits into from
Sep 3, 2024
Merged

fix(sem): fix crash routine pragma redefinition #1445

merged 3 commits into from
Sep 3, 2024

Commits on Sep 3, 2024

  1. fix compiler crash in routine pragma redefinition 

    error reporting

This existed because of unhelpful assertions in legacy reports.
    @saem
    saem committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    2d6dc8f View commit details
    Browse the repository at this point in the history

  2. clean-up error message 

    fix code that was clowning instead of actually using string formatting

still not qutie right as there is _some_ flexibility with pragmas on
definitions
    @saem
    saem committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    061fc4d View commit details
    Browse the repository at this point in the history

  3. Update compiler/front/cli_reporter.nim 

    Co-authored-by: zerbina <100542850+zerbina@users.noreply.github.com>
    @saem @zerbina
    saem and zerbina authored Sep 3, 2024
    Configuration menu
    Copy the full SHA
    c2115f5 View commit details
    Browse the repository at this point in the history