-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
niminst: generate archive manifest after build #219
Conversation
@@ -769,6 +770,51 @@ proc checkedShellExec(cmd: string) = | |||
if exitCode != 0: | |||
raise newExternalProgramError(exitCode) | |||
|
|||
proc computeChecksum(file: string): string = | |||
## Calculate the SHA256 hash for `file`. | |||
let p = startProcess( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hah, I thought we'd have a standard library call for this, oh well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor, otherwise g2g
tools/niminst/niminst.nim
Outdated
stderr.write p.outputStream.readAll() | ||
raise newExternalProgramError(exitCode) | ||
else: | ||
# OpenSSL produce an output in this format: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# OpenSSL produce an output in this format: | |
# OpenSSL produces output in this format: |
tools/niminst/niminst.nim
Outdated
cpu: string ## The binary archive target CPU | ||
of Source: | ||
discard | ||
|
||
proc archiveDist(c: var ConfigData) = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
proc archiveDist(c: var ConfigData) = | |
proc createArchiveDist(c: var ConfigData) = |
If we only day it a few times then it's not worth saving the characters and it completely obviates the comment.
This allows tools to figure out what was created without doing guesswork on file name. Co-authored-by: Saem Ghani <saemghani+github@gmail.com>
e5987ab
to
d0a5b85
Compare
bors r+ |
Build succeeded: |
This allows tools to figure out what was created without doing guesswork
on file name.
This will be used by the continuous delivery pipeline.