stdlib: move varargsLen to macros.nim
#307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bors r+ |
bors bot
added a commit
that referenced
this pull request
May 12, 2022
307: stdlib: move `varargsLen` to `macros.nim` r=saem a=zerbina It could only be implemented in `system` due to a misuse of a compiler magic, making it dependent on a VM implementation detail. ### Changes - `varagsLen` is now located in `macros.nim` and doesn't depend on a compiler magic anymore - the `tvarargslen.nim` test is moved to the `macros` category Co-authored-by: zerbina <100542850+zerbina@users.noreply.github.com>
zerbina
force-pushed
the
varargslen-macros
branch
from
f695df6 to
b871fa5
Compare
|
Canceled. |
|
I missed adding an import as well as a wrong white-space fix, sorry |
zerbina
force-pushed
the
varargslen-macros
branch
from
b871fa5 to
97efb88
Compare
It could only be implemented in `system` due to a misuse of a compiler magic, making it dependent on a VM implementation detail. ## Changes - `varagsLen` is now located in `macros.nim` and doesn't depend on a compiler magic anymore - the `tvarargslen.nim` test is moved to the `macros` category
|
Bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It could only be implemented in
systemdue to a misuse of acompiler magic, making it dependent on a VM implementation detail.
Changes
varagsLenis now located inmacros.nimand doesn't depend on acompiler magic anymore
tvarargslen.nimtest is moved to themacroscategoryThe macro was originally added to
systemin order to make it available with no extra imports. There also was a discussion in the original PR about whether or not this macro should even be needed in the first place, but the PR was merged without the discussion concluding.