Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lang: remove for loop and case statement macros #413

Merged

Conversation

saem
Copy link
Collaborator

@saem saem commented Aug 6, 2022

There are better ways to do these sorts of things.

There are better ways to do these sorts of things.
@saem
Copy link
Collaborator Author

saem commented Aug 6, 2022

Bots r+

@disruptek
Copy link
Contributor

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 6, 2022

Build succeeded:

@bors bors bot merged commit 086304b into nim-works:devel Aug 6, 2022
@SolitudeSF
Copy link
Contributor

SolitudeSF commented Aug 7, 2022

There are better ways to do these sorts of things.

like what? is there a relevant discussion/motivation i can read?

@saem
Copy link
Collaborator Author

saem commented Aug 7, 2022

There are better ways to do these sorts of things.

like what? is there a relevant discussion/motivation i can read?

No, because there isn't a one to one replacement being considered. Considering the lack of any sort of working interfaces starting with something like enumerable or iterable would be big leap forward. As for case, start making them less limited from the start. Performance issues get mitigated in many situations here and elsewhere with some partial evaluation.

@SolitudeSF
Copy link
Contributor

SolitudeSF commented Aug 7, 2022

i barely understand what are you trying to say here. im gonna have to ask more directly: why are for loop macros removed?

@saem
Copy link
Collaborator Author

saem commented Aug 7, 2022

i barely understand what are you trying to say here. im gonna have to ask more directly: why are for loop macros removed?

Sorry, fat fingered the edit button at first.

I don't want this or many other features in the language. The approach is:

  1. More obvious things should be done
  2. See if those are insufficient
  3. Discuss if this or some other approach is required

@SolitudeSF
Copy link
Contributor

okay, now i get it.
just unfortunate to see the feature i like go.

@saem
Copy link
Collaborator Author

saem commented Aug 7, 2022

okay, now i get it. just unfortunate to see the feature i like go.

It's useful to you, so it'd be helpful to capture some of the reasoning why here if you're up for sharing, thanks. #289 (comment)

@haxscramper haxscramper added this to the Sem phase refactoring milestone Nov 21, 2022
@saem saem deleted the saem-remove-for-loop-and-case-stmt-macros branch January 22, 2023 18:41
@haxscramper haxscramper added the simplification Removal of the old, unused, unnecessary or un/under-specified language features. label Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
simplification Removal of the old, unused, unnecessary or un/under-specified language features.
Development

Successfully merging this pull request may close these issues.

4 participants