Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generate method dispatchers prior to code-gen #734

Merged
merged 1 commit into from
Jun 1, 2023
Merged

generate method dispatchers prior to code-gen #734

merged 1 commit into from
Jun 1, 2023

Commits on Jun 1, 2023

  1. generate method dispatchers prior to code-gen 

    Summary
=======

Move the method dispatcher generation out of the code generators (`cgen`
and `jsgen`) and into the orchestrators. This is another step towards
unifying the backend processing.

Methods are now also subject to dead-code elimination, meaning that if
none of the methods attached to an object hierarchy is called, no code
will be generated for them.

Details
=======

The dispatchers do not appear in calls prior to `transf`, so the DCE
implementation used by IC backend cannot analyze them. For this reason,
`cgen` continues to special-case methods them.

In addition, remove the unused `objHasKidsValid` enum value.

Future Direction
----------------

Given that all backends need to generate method dispatchers, this step
(lowering methods into procedures) should happen through some common
facility in the future.
    @zerbina
    zerbina committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    3923d3a View commit details
    Browse the repository at this point in the history