cgen: fix regression with .nodecl consts
#785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary ======= Fix a regression where the `.nodecl` pragma was ignored by the C code generator in the context of constants. Details ======= Apart from the fix, the single-use `genConstSetup` is inlined into `useConst`. Since the loc for constants is setup in `genConstDefinition` (which is always called before `useConst`), the `fillLoc` call is not added to `useConst` (this is also a step towards `fillLoc` only being used in procedures responsible for definitions). In addition, a test for the current behaviour of imported `.nodecl` constants is added.
zerbina
added
bug
saem
approved these changes
Jul 7, 2023
|
/merge |
|
Merge requested by: @saem Contents after the first section break of the PR description has been removed and preserved below:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix a regression where the C code generator ignored the
.nodeclpragma for constants.
Details
Apart from the fix, the single-use
genConstSetupis inlined intouseConst. Since the loc for constants is setup ingenConstDefinition(which is always called before
useConst), thefillLoccall is notadded to
useConst(this is also a step towardsfillLoconly beingused in procedures responsible for definitions).
In addition, a test for the current behaviour of imported
.nodecl