-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
internal: move MIR generation DSL to mirconstr
#793
Merged
chore-runner
merged 9 commits into
nim-works:devel
from
zerbina:mirgen-move-dsl-to-mirconstr
Jul 12, 2023
Merged
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
64c5f18
move the MIR generation DSL to `mirconstr`
zerbina f8b10a7
mirconstr: add `emit`, `symbol`, and `opParam`
zerbina 32f75cb
mirconstr: introduce the `predicate` meta-operand
zerbina 25cd0ba
mirconstr: remove `|=>`, `=>|`, and `previous`
zerbina 5c25c56
mirconstr: make the names consistent
zerbina bee5e6d
injectdestructors: use the chain DSL
zerbina cd63a8c
mirbridge: use the chain DSL
zerbina 4b313b7
mirconstr: add documentation
zerbina 3746c1c
mirconstr: document `voidOut`
zerbina File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure I have that quite right, this is from what I could gather based on usage. initially I was seeing if I could come up with a better name, settled on a doc string might help. (soft suggestion)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, that sounds correct. I added it plus some additional elaboration.
In general, the 'void' operator/node acts as both a
discard
and as a delimiter for expressions ('call' operators that yield nothing also need to be followed by 'void').