nimscript: fix compiler crash with .header procs
#800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary ======= Fix the compiler crashing when running NimScript files that directly contain procedure definitions using the `.header` or `.dynlib` pragma. Details ======= The module of a NimScript didn't use its own `IdGenerator`, but instead re-used the `IdGenerator` instance belonging to the `ModuleGraph`. Apart from leading to all symbols created as part of semantically analysing the module being not attached to any module, this also caused an `IndexDefect` when processing a `.header`/`.dynlib` pragma, as there the module ID provided by the `IdGenerator` (which is -1 for the `ModuleGraph`'s) is used as an index into to the `TLib` storage. A dedicated `IdGenerator` is now created for a NimScript file, both fixing the crash and guara the invariant that the module ID provided by a `PContext`'s ID generator is a valid `FileIndex`.
saem
approved these changes
Jul 16, 2023
|
/merge |
|
Merge requested by: @saem Contents after the first section break of the PR description has been removed and preserved below:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix the compiler crashing when running NimScript files that directly
contain procedure definitions using the
.headeror.dynlibpragma.Details
The module of a NimScript didn't use its own
IdGenerator, but insteadre-used the
IdGeneratorinstance belonging to theModuleGraph. Apartfrom leading to all symbols created as part of semantically analysing
the module being not attached to any module, this also caused an
IndexDefectwhen processing a.header/.dynlibpragma, as there themodule ID provided by the
IdGenerator(which is -1 for theModuleGraph's) is used as an index into to theTLibstorage.A dedicated
IdGeneratoris now created for a NimScript file, bothfixing the crash and guaranteeing that the module ID provided by a
PContext's ID generator is a validFileIndex.