front: skip non-existent paths in gcc depfiles #803
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saem
requested changes
Jul 17, 2023
compiler/front/depfiles.nim
Outdated
| @@ -25,13 +25,14 @@ proc writeDepsFile*(g: ModuleGraph) = | |||
| f.writeLine(toFullPath(g.config, k)) | |||
| f.close() | |||
|
|
|||
| func makefileQuoted(path: string): string = | |||
There was a problem hiding this comment.
Isn't there already a pre-existing procedure for this like quote shell?
Suggested change
| func makefileQuoted(path: string): string = | |
| func quoteFilepath(path: string): string = |
Also, this seems like a better name
There was a problem hiding this comment.
Isn't there already a pre-existing procedure for this like quote shell?
Yes, but only subset of that is needed
There was a problem hiding this comment.
Also, this seems like a better name
Committed.
| if path.len == 0: | ||
| depfile.write(target.makefileQuoted & ": \\" & '\n') | ||
| for path in paths: | ||
| if path.len == 0 or not fileExists(path): |
There was a problem hiding this comment.
I don't recall when this is called, but if this is meant to produce a reusable description then this shouldn't be filtered here.
There was a problem hiding this comment.
Updated PR message
CyberTailor
changed the title
|
Closing until I remember what package caused this behavior |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There could be non-existent files in
conf.m.fileInfosthat prevented GCC-style depfiles from behaving correctly. This commit filters them out.Details
Also create a helper function to quote paths for Unix Makefiles.