jsgen: fix incorrect float32-literal behaviour
#824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary ======= Narrow the value of 32-bit float-literal nodes prior to rendering them, which fixes `float32` literals having an unexpected run-time value when their value as-written is not fully representable with the precision of a 32-bit float. Details ======= Instead of using `toStrMaxPrecision`, which would add an unwanted `f` suffix, rendering the float value to text is done by directly calling `addFloatRoundtrip`, which `toStrMaxPrecision` uses internally.
zerbina
added
bug
saem
approved these changes
Aug 2, 2023
|
/merge |
|
Merge requested by: @saem Contents after the first section break of the PR description has been removed and preserved below:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Narrow the value of 32-bit float-literal nodes prior to rendering them,
which fixes
float32literals having an unexpected run-time valuewhen their value as-written is not fully representable with the
precision of a 32-bit float.
Details
Instead of using
toStrMaxPrecision, which would add an unwantedfsuffix, rendering the float value to text is done by directly calling
addFloatRoundtrip, whichtoStrMaxPrecisionuses internally.