semtypinst: remove the "meta-types allowed" mode #866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerbina
added
compiler/sem
saem
approved these changes
Sep 1, 2023
Comment on lines
+108
to
+109
| # types. Used as a work-around for instantiation | ||
| # cache issues |
There was a problem hiding this comment.
excellent, emphasizes that it needs to be fixed rather than actually required.
|
/merge |
|
Merge requested by: @saem Contents after the first section break of the PR description has been removed and preserved below: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With all users of the mode gone, the mode itself is removed, preventing
it from becoming accidentally relied on again.
Details
TReplTypeVars.allowMetaTypesfieldallowedMetaTypesfield itselfallowedMetaTypesparameter frominstGenericContainerCloses #846