Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: remove disabled code in liftdestructors #884

Conversation

bung87
Copy link
Contributor

@bung87 bung87 commented Sep 9, 2023

Remove commented-out markUsed calls within the liftdestructors
module. It's unlikely that they are going to be included again,
and removing them prevents the calls from showing up in whole-
project text searches.

@bung87 bung87 changed the title remove markUsed comments in liftdestructors sem: remove markUsed comments in liftdestructors Sep 9, 2023
@zerbina zerbina changed the title sem: remove markUsed comments in liftdestructors internal: remove disabled code in liftdestructors Sep 9, 2023
Copy link
Collaborator

@zerbina zerbina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

I've updated the title and PR message, and if you're okay with the changes, please ping me and I'll start the merge.

@bung87
Copy link
Contributor Author

bung87 commented Sep 9, 2023

Thank you for the PR!

I've updated the title and PR message, and if you're okay with the changes, please ping me and I'll start the merge.

Thank you, that's exactly the thoughts.

@zerbina
Copy link
Collaborator

zerbina commented Sep 9, 2023

/merge

@github-actions
Copy link

github-actions bot commented Sep 9, 2023

Merge requested by: @zerbina

Contents after the first section break of the PR description has been removed and preserved below:


@chore-runner chore-runner bot added this pull request to the merge queue Sep 9, 2023
Merged via the queue into nim-works:devel with commit 1a9e85e Sep 9, 2023
18 checks passed
@zerbina zerbina added compiler/sem Related to semantic-analysis system of the compiler simplification Removal of the old, unused, unnecessary or un/under-specified language features. labels Sep 9, 2023
@bung87 bung87 deleted the remove-markUsed-comment-in-liftdestructors branch September 11, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler/sem Related to semantic-analysis system of the compiler simplification Removal of the old, unused, unnecessary or un/under-specified language features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants