internal: separate VM profiler data from ConfigRef
#899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary ======= Store the data collected by the VM profiler with the profiler itself, instead of storing it with the global configuration state (`ConfigRef`). This allows for moving the profiler-related data types closer to the `vmprofiler` module, and it also shrinks the surface of `ConfigRef` and the `options` module. Details ======= * move all profiler-related data types to `vmdef`; they should ideally be placed in the `vmprofiler` module, but that would currently introduce cyclic dependencies * `vmprofiler.dump` now accepts a `Profiler` instance; for rendering the data associated with a VM context, the new `compilerbridge.dumpVmProfilerData` procedure is now used
saem
approved these changes
Sep 14, 2023
|
/merge |
|
Merge requested by: @saem Contents after the first section break of the PR description has been removed and preserved below:
|
bung87
pushed a commit
to bung87/nimskull
that referenced
this pull request
Sep 16, 2023
## Summary Store the data collected by the VM profiler with the profiler itself, instead of storing it with the global configuration state (`ConfigRef`). This allows for moving the profiler-related data types closer to the `vmprofiler` module, and it also shrinks the surface of `ConfigRef` and the `options` module. ## Details * move all profiler-related data types to `vmdef`; they should ideally be placed in the `vmprofiler` module, but that would currently introduce cyclic dependencies * `vmprofiler.dump` now accepts a `Profiler` instance; for rendering the data associated with a VM context, the new `compilerbridge.dumpVmProfilerData` procedure is now used
bung87
pushed a commit
to bung87/nimskull
that referenced
this pull request
Sep 23, 2023
## Summary Store the data collected by the VM profiler with the profiler itself, instead of storing it with the global configuration state (`ConfigRef`). This allows for moving the profiler-related data types closer to the `vmprofiler` module, and it also shrinks the surface of `ConfigRef` and the `options` module. ## Details * move all profiler-related data types to `vmdef`; they should ideally be placed in the `vmprofiler` module, but that would currently introduce cyclic dependencies * `vmprofiler.dump` now accepts a `Profiler` instance; for rendering the data associated with a VM context, the new `compilerbridge.dumpVmProfilerData` procedure is now used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Store the data collected by the VM profiler with the profiler itself,
instead of storing it with the global configuration state (
ConfigRef).This allows for moving the profiler-related data types closer to the
vmprofilermodule, and it also shrinks the surface ofConfigRefandthe
optionsmodule.Details
vmdef; they should ideallybe placed in the
vmprofilermodule, but that would currentlyintroduce cyclic dependencies
vmprofiler.dumpnow accepts aProfilerinstance; for rendering thedata associated with a VM context, the new
compilerbridge.dumpVmProfilerDataprocedure is now used