-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
internal: separate VM profiler data from ConfigRef
#899
internal: separate VM profiler data from ConfigRef
#899
Conversation
Summary ======= Store the data collected by the VM profiler with the profiler itself, instead of storing it with the global configuration state (`ConfigRef`). This allows for moving the profiler-related data types closer to the `vmprofiler` module, and it also shrinks the surface of `ConfigRef` and the `options` module. Details ======= * move all profiler-related data types to `vmdef`; they should ideally be placed in the `vmprofiler` module, but that would currently introduce cyclic dependencies * `vmprofiler.dump` now accepts a `Profiler` instance; for rendering the data associated with a VM context, the new `compilerbridge.dumpVmProfilerData` procedure is now used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heck yeah, more modular compiler, all that much easier to understand. 🎉
/merge |
Merge requested by: @saem Contents after the first section break of the PR description has been removed and preserved below:
|
## Summary Store the data collected by the VM profiler with the profiler itself, instead of storing it with the global configuration state (`ConfigRef`). This allows for moving the profiler-related data types closer to the `vmprofiler` module, and it also shrinks the surface of `ConfigRef` and the `options` module. ## Details * move all profiler-related data types to `vmdef`; they should ideally be placed in the `vmprofiler` module, but that would currently introduce cyclic dependencies * `vmprofiler.dump` now accepts a `Profiler` instance; for rendering the data associated with a VM context, the new `compilerbridge.dumpVmProfilerData` procedure is now used
## Summary Store the data collected by the VM profiler with the profiler itself, instead of storing it with the global configuration state (`ConfigRef`). This allows for moving the profiler-related data types closer to the `vmprofiler` module, and it also shrinks the surface of `ConfigRef` and the `options` module. ## Details * move all profiler-related data types to `vmdef`; they should ideally be placed in the `vmprofiler` module, but that would currently introduce cyclic dependencies * `vmprofiler.dump` now accepts a `Profiler` instance; for rendering the data associated with a VM context, the new `compilerbridge.dumpVmProfilerData` procedure is now used
Summary
Store the data collected by the VM profiler with the profiler itself,
instead of storing it with the global configuration state (
ConfigRef
).This allows for moving the profiler-related data types closer to the
vmprofiler
module, and it also shrinks the surface ofConfigRef
andthe
options
module.Details
vmdef
; they should ideallybe placed in the
vmprofiler
module, but that would currentlyintroduce cyclic dependencies
vmprofiler.dump
now accepts aProfiler
instance; for rendering thedata associated with a VM context, the new
compilerbridge.dumpVmProfilerData
procedure is now used