build nimsuggest_testing for local testing
#900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saem
reviewed
Sep 15, 2023
Co-authored-by: Saem Ghani <saemghani+github@gmail.com>
saem
changed the title
nimsuggest_testing for local testing
|
@bung87 have a read of the latest PR title + body. |
|
/merge |
|
Merge requested by: @saem Contents after the first section break of the PR description has been removed and preserved below:
|
bung87
added a commit
to bung87/nimskull
that referenced
this pull request
Sep 16, 2023
<!--- The Pull Request (=PR) message is what will get automatically used as the commit message when the PR is merged. Make sure that no line is longer than 72 characters --> ## Summary Make local nimsuggest testing easier by having the nimsuggest `tester` build the `nimsuggest_testing` binary as part of the run. ## Details Previous `nimsuggest_testing` is built in CI environment which meant it is not available when running tests locally. Now if `tester` can't find the `nimsuggest_testing` binary, it's built before running any tests. To test locally, as per the module comments: > When debugging, to run a single test, use for e.g.: > `nim r nimsuggest/tester.nim nimsuggest/tests/tsug_accquote.nim` --------- Co-authored-by: Saem Ghani <saemghani+github@gmail.com>
bung87
added a commit
to bung87/nimskull
that referenced
this pull request
Sep 23, 2023
<!--- The Pull Request (=PR) message is what will get automatically used as the commit message when the PR is merged. Make sure that no line is longer than 72 characters --> ## Summary Make local nimsuggest testing easier by having the nimsuggest `tester` build the `nimsuggest_testing` binary as part of the run. ## Details Previous `nimsuggest_testing` is built in CI environment which meant it is not available when running tests locally. Now if `tester` can't find the `nimsuggest_testing` binary, it's built before running any tests. To test locally, as per the module comments: > When debugging, to run a single test, use for e.g.: > `nim r nimsuggest/tester.nim nimsuggest/tests/tsug_accquote.nim` --------- Co-authored-by: Saem Ghani <saemghani+github@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Make local nimsuggest testing easier by having the nimsuggest
testerbuild the
nimsuggest_testingbinary as part of the run.Details
Previous
nimsuggest_testingis built in CI environment which meant itis not available when running tests locally. Now if
testercan't findthe
nimsuggest_testingbinary, it's built before running any tests.To test locally, as per the module comments: