-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(sem): clean up hasUnresolvedParams
#957
refactor(sem): clean up hasUnresolvedParams
#957
Conversation
I'm not sure I agree with their removals. They do convey additional information, and they also provide a customization point (e.g., for placing an assertion). For example, I think that In any case, a routine having a name longer than its implementation is by itself not a reason for removal. To be clear, I have no problem with the disabled code being removed; removing the procedures as a whole is what I feel uneasy about. |
I agree with your points, but still problem remains |
What do you mean? I'm not sure I understand.
Yep, the unused flag is confusing -- it should be removed together with the disabled code. |
bc12f85
to
4259156
Compare
…Flags` parameter
4259156
to
1144ce8
Compare
tfUnresolved
usagesproc hasUnresolvedParams
disabled code and obsolete parameter
followed your suggestions, I messed up git history, sorry. |
proc hasUnresolvedParams
disabled code and obsolete parameterhasUnresolvedParams
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bung87 I've reworded the PR message a bit and shortened the title. Once you've taken a look at the updated message and title, please ping me and I'll start the merge.
@zerbina Thank you! nice! |
/merge |
Merge requested by: @zerbina Contents after the first section break of the PR description has been removed and preserved below:
|
Summary
Remove disabled code from the
hasUnresolvedParams
procedure. Thecode has been disabled for 7 years and is unlikely to become used
again.
Details
flags: TExprFlags
parameter