stdlib: clean up coloredResult
#962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary ======= Slightly refactor the implementation of the `colortext.coloredResult` template and remove its obsolete `endResult` helper template. Details ======= - mention the injected `addf` routine in the documentation - remove the unnecessary `static` block around the `.error` directive - shorten the compile-time error message for when no `result` variable exists - remove the `endResult` helper template; the `vmgen` bug that necessitated it is fixed - turn the `addf` procedure into a template and mark it as `.used`, preventing `XDeclaredButNotUsed` warnings
haxscramper
approved these changes
Oct 14, 2023
|
/merge |
|
Merge requested by: @saem Contents after the first section break of the PR description has been removed and preserved below:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Slightly refactor the implementation of the
colortext.coloredResulttemplate and remove its obsolete
endResulthelper template.Details
addfroutine in the documentationstaticblock around the.errordirectiveresultvariableexists
endResulthelper template; thevmgenbug thatnecessitated it is fixed
addfprocedure into a template and mark it as.used,preventing
XDeclaredButNotUsedwarnings