Wasm-JS interactivity, part two: staking roundtrip #1350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 66.93% // Head: 66.59% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## albatross #1350 +/- ##
=============================================
- Coverage 66.93% 66.59% -0.34%
=============================================
Files 407 408 +1
Lines 51558 51796 +238
=============================================
- Hits 34508 34494 -14
- Misses 17050 17302 +252
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
jsdanielh
reviewed
Feb 20, 2023
|
LGTM |
sisou
force-pushed
the
soeren/wasm-ext
branch
from
10d0b2d to
e4db562
Compare
|
Thanks @jsdanielh, I missed those import orderings! I also applied all your other suggestions 👍 |
jsdanielh
approved these changes
Feb 21, 2023
|
@sisou I will be rebasing it to get it merged |
- Introduces a TransactionBuilder class that is instantiated from the client and receives the client's networkId and blockchain proxy, to access the current head block number, allowing users to omit these when creating transactions. - Adds a `sign(keyPair)` method on `Transaction` that automatically signs the transaction with the correct signature(s) format. - Add a constructor function to `Transaction` to allow creating arbitrary transactions which are not yet covered by the transaction builder.
jsdanielh
force-pushed
the
soeren/wasm-ext
branch
from
e4db562 to
303294c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Makes it possible to easily create and sign all transactions necessary to start staking, add stake, update delegation, and unstake.
TransactionBuilderclass that is instantiated from the client and receives the client'snetwork_idand a blockchain proxy (to access the current head block number), allowing users to omit these when creating transactions.tx.sign(keyPair)method that automatically signs the transaction with the correct signature(s) format if possible.Transactionto allow the creation of arbitrary transactions which the transaction builder does not yet cover.This relates to #1339.
Pull request checklist
clippyandrustfmtwarnings.