Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose getTransactionsByAddress to JS #1356

Merged
merged 3 commits into from
Mar 3, 2023
Merged

Expose getTransactionsByAddress to JS #1356

merged 3 commits into from
Mar 3, 2023

Conversation

viquezclaudio
Copy link
Member

@viquezclaudio viquezclaudio commented Feb 23, 2023 •
edited
Loading

Provide functionality that queries the network in order to get transactions that belong to some specific address.
For this particular request, history nodes would provide the transaction details and an inclusion proof of those transactions.
The final list of transactions are serialized and returned to JS via a JsValue

@viquezclaudio viquezclaudio added the WIP This pull request is still work in progress label Feb 23, 2023
sisou
sisou reviewed Feb 23, 2023
View reviewed changes
web-client/src/lib.rs Outdated Show resolved Hide resolved
web-client/src/lib.rs Outdated Show resolved Hide resolved
web-client/src/lib.rs Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Feb 23, 2023 •
edited
Loading

Codecov Report

Patch coverage: 1.36% and project coverage change: -0.14 ⚠️

Comparison is base (f6a54b2) 66.40% compared to head (8e78b49) 66.27%.

❗ Current head 8e78b49 differs from pull request most recent head 22f575c. Consider uploading reports for the commit 22f575c to get more accurate results

Additional details and impacted files 
@@              Coverage Diff              @@
##           albatross    #1356      +/-   ##
=============================================
- Coverage      66.40%   66.27%   -0.14%     
=============================================
  Files            408      408              
  Lines          51990    52314     +324     
=============================================
+ Hits           34523    34669     +146     
- Misses         17467    17645     +178
Flag Coverage Δ
unittests 66.27% <1.36%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
blockchain/src/blockchain/history_sync.rs 80.80% <ø> (ø)
blockchain/src/history/history_store.rs 83.37% <ø> (ø)
consensus/src/consensus/consensus_proxy.rs 6.31% <0.00%> (-23.69%) ⬇️
consensus/src/messages/handlers.rs 63.01% <0.00%> (-3.26%) ⬇️
consensus/src/messages/mod.rs 21.42% <ø> (ø)
network-interface/src/network.rs 25.00% <ø> (ø)
network-libp2p/src/connection_pool/behaviour.rs 45.72% <0.00%> (-2.34%) ⬇️
network-libp2p/src/error.rs 45.45% <ø> (ø)
network-libp2p/src/network.rs 71.27% <0.00%> (-2.55%) ⬇️
network-mock/src/network.rs 82.49% <0.00%> (-1.41%) ⬇️
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sisou sisou mentioned this pull request Feb 27, 2023
Closed
10 tasks
@viquezclaudio viquezclaudio force-pushed the viquezcl/wasm-infra branch 2 times, most recently from 0ffa727 to d174588 Compare February 27, 2023 21:34
@viquezclaudio viquezclaudio changed the title Expose RequestTransactionsByAddress to JS ExposeGetTransactionsByAddress to JS Feb 27, 2023
@viquezclaudio viquezclaudio force-pushed the viquezcl/wasm-infra branch 3 times, most recently from f2097ca to 4bb2939 Compare February 28, 2023 15:23
@viquezclaudio viquezclaudio removed the WIP This pull request is still work in progress label Feb 28, 2023
jsdanielh
jsdanielh requested changes Mar 1, 2023
View reviewed changes
blockchain/src/history/history_store.rs Outdated Show resolved Hide resolved
consensus/src/consensus/consensus_proxy.rs Outdated Show resolved Hide resolved
consensus/src/consensus/consensus_proxy.rs Outdated Show resolved Hide resolved
consensus/src/consensus/consensus_proxy.rs Outdated Show resolved Hide resolved
web-client/Cargo.toml Outdated Show resolved Hide resolved
consensus/src/consensus/consensus_proxy.rs Outdated Show resolved Hide resolved
network-libp2p/src/connection_pool/behaviour.rs Outdated Show resolved Hide resolved
network-libp2p/src/network.rs Outdated Show resolved Hide resolved
network-libp2p/src/network.rs Outdated Show resolved Hide resolved
network-libp2p/src/network.rs Outdated Show resolved Hide resolved
@viquezclaudio viquezclaudio force-pushed the viquezcl/wasm-infra branch 2 times, most recently from a16de38 to 3b74370 Compare March 1, 2023 20:12
@viquezclaudio
Copy link
Member Author

PR back to you @jsdanielh

jsdanielh
jsdanielh reviewed Mar 2, 2023
View reviewed changes
Copy link
Member

@jsdanielh jsdanielh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple more of comments

network-libp2p/src/connection_pool/behaviour.rs Show resolved Hide resolved
network-libp2p/src/network.rs Outdated Show resolved Hide resolved
network-libp2p/src/network.rs Show resolved Hide resolved
web-client/Cargo.toml Outdated Show resolved Hide resolved
web-client/src/lib.rs Outdated Show resolved Hide resolved
consensus/src/consensus/consensus_proxy.rs Outdated Show resolved Hide resolved
@sisou sisou force-pushed the viquezcl/wasm-infra branch from 6fc4fec to 0e3332d Compare March 2, 2023 14:13
@viquezclaudio viquezclaudio force-pushed the viquezcl/wasm-infra branch 2 times, most recently from 603d82a to ffe9ebe Compare March 2, 2023 15:59
jsdanielh
jsdanielh reviewed Mar 2, 2023
View reviewed changes
consensus/src/messages/handlers.rs Outdated Show resolved Hide resolved
consensus/src/messages/handlers.rs Show resolved Hide resolved
network-libp2p/src/network.rs Outdated Show resolved Hide resolved
network-libp2p/src/network.rs Outdated Show resolved Hide resolved
network-libp2p/src/connection_pool/behaviour.rs Outdated Show resolved Hide resolved
@sisou sisou force-pushed the viquezcl/wasm-infra branch from 80a0c61 to 8e78b49 Compare March 2, 2023 22:38
@sisou sisou changed the title ExposeGetTransactionsByAddress to JS Expose getTransactionsByAddress to JS Mar 2, 2023
viquezclaudio and others added 3 commits March 2, 2023 18:53
@viquezclaudio @jsdanielh
Expose GetTransactionsByAddress to JS
255c2bc 
Provide functionality that queries the network in order to get transactions that belong to some specific address.
For this particular request, history nodes would provide the transaction details and an inclusion proof of those transactions.
The final list of transactions are serialized and returned to JS via a JsValue
@sisou @jsdanielh
Fix proofs for RequestTransactionsProof for ongoing epochs
f121544
@viquezclaudio @jsdanielh
Applied further PR comments
22f575c
@jsdanielh jsdanielh force-pushed the viquezcl/wasm-infra branch from e2467f3 to 22f575c Compare March 3, 2023 00:54
@jsdanielh jsdanielh merged commit 22f575c into albatross Mar 3, 2023
@jsdanielh jsdanielh deleted the viquezcl/wasm-infra branch March 3, 2023 06:02
@sisou sisou mentioned this pull request Mar 3, 2023
Merged
3 tasks
@sisou sisou added the WASM label Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsdanielh jsdanielh jsdanielh approved these changes

@sisou sisou sisou approved these changes

Assignees
No one assigned
Labels
WASM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@viquezclaudio @sisou @jsdanielh