Optionally reset the idle timeout when sending a chunk #1503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase onto current master so that CI runs properly. I am planning to do a release with this and other things soon. |
* The default behavior (sending data is considered being idle) is maintained. * There is a new protocol option for http and http2 which makes the idle timeout be reset when data is sent to the client.
rjmac
force-pushed
the
idle-timeout-sends
branch
from
e1211c6 to
37dd628
Compare
|
I will keep the tests and do a different implementation that updates the idle timeout on all cases of sending on the socket, not just when data is sent. |
|
Merged, thanks! Note that the option was renamed to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
maintained.
the idle timeout be reset when data is sent to the client.
This implements #1502.