Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject request with invalid Connection header format #1605

Closed
wants to merge 1 commit into from

Conversation

0x42
Copy link

@0x42 0x42 commented Feb 17, 2023

Cowboy reject request with invalid Connection header format instead of throwing exception.

@0x42 0x42 changed the title Reject invalid Connection header format Reject request with invalid Connection header format Feb 17, 2023
@zinid
Copy link

zinid commented Mar 16, 2023

@essen do we need to improve anything in the PR? We need this fix badly.

Regarding failed CI checks: I think this is unrelated to the changes. Correct me if I am wrong :)

@essen
Copy link
Member

essen commented Mar 16, 2023

Nothing obvious just busy with other things. I'll try to schedule time to make a release and will handle the pending PRs at the same time.

@essen essen added this to the 2.11 milestone Nov 23, 2023
@essen
Copy link
Member

essen commented Dec 5, 2023

Please rebase onto current master so that CI runs properly. I am planning to do a release with this and other things soon.

@0x42 0x42 force-pushed the malformed_header_crash branch from 869fd34 to 72b9fa4 Compare December 6, 2023 08:50
@0x42
Copy link
Author

0x42 commented Dec 6, 2023

Unfortunately CI failed (((
like here https://github.com/ninenines/cowboy/actions/runs/7114039692/job/19367589145

@essen
Copy link
Member

essen commented Dec 6, 2023

The failure on OTP master is expected as there's a bug in OTP causing it. The one on 26.1 is not but likely a flake so I don't think there's any problem. Cheers.

@essen
Copy link
Member

essen commented Dec 15, 2023

Merged with tweaks and an additional test for HTTP/1.0. Closing, thanks!

@essen essen closed this Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants