Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dry run (-n) error if the builddir directory does not exist in 1.12.0 #2431

Closed
sean-eveson-sony opened this issue Apr 30, 2024 · 2 comments · Fixed by #2440
Closed

Dry run (-n) error if the builddir directory does not exist in 1.12.0 #2431

sean-eveson-sony opened this issue Apr 30, 2024 · 2 comments · Fixed by #2440

Comments

@sean-eveson-sony
Copy link

Hi. I'm using Ninja 1.12.0 on Windows.

Since 1.12.0 dry run commands will produce an error such as error: WriteFile(ninja_builddir/.ninja_lock): Unable to create file. No such file or directory if the builddir directory does not already exist. I reproduced the error with a simple build.ninja file and running ninja -n:

builddir = ninja_builddir

rule cc
    command = clang -c $in -o $out

build test.obj: cc test.cpp

Thanks!

@jhasse jhasse added the bug label Apr 30, 2024
@jhasse jhasse added this to the 1.13.0 milestone Apr 30, 2024
@jhasse
Copy link
Collaborator

jhasse commented May 5, 2024

I think we should fix this regression and then release 1.12.1. Help wanted :)

@jhasse
Copy link
Collaborator

jhasse commented May 5, 2024

@jdrouhard can you have a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants