New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't attempt to write and stat the lock file during dry runs #2440

Merged

jhasse merged 1 commit into ninja-build:master from jdrouhard:dry-run-fix

May 6, 2024

Contributor

jdrouhard commented May 5, 2024

Fixes #2431


          fix: don't attempt to write and stat the lock file during dry runs

9f0f6ad

jdrouhard force-pushed the dry-run-fix branch from e533a0e to 9f0f6ad Compare

May 5, 2024 17:39

Collaborator

jhasse commented May 6, 2024

Thanks! We're really should have more (integration) tests for this stuff ...

jhasse added this to the 1.13.0 milestone

jhasse merged commit 554579d into ninja-build:master

11 checks passed

jhasse modified the milestones: 1.13.0, 1.12.1

jdrouhard deleted the dry-run-fix branch

May 13, 2024 19:39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet