Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REG 1.11->1.12] Screen updates are extremely slow on Windows #2435

Closed
orgads opened this issue May 4, 2024 · 2 comments · Fixed by #2437
Closed

[REG 1.11->1.12] Screen updates are extremely slow on Windows #2435

orgads opened this issue May 4, 2024 · 2 comments · Fixed by #2437
Labels
bug windows
Milestone
1.12.1

Comments

@orgads
Copy link
Contributor

orgads commented May 4, 2024

With Ninja 1.12, the progress updates are horribly slow, and it looks like the cursor passes through all the characters one by one. It looks like running on 80386...

With 1.11 it worked much better.

Run example:
ninja-1 12
@orgads
Copy link
Contributor Author

orgads commented May 4, 2024 •
edited
Loading

Bisected to #2321 which added:

setlocale(LC_ALL, "");

Removing this line solves this.

@orgads orgads mentioned this issue May 4, 2024
Merged
orgads added a commit to orgads/ninja that referenced this issue May 4, 2024
@orgads
RealDiskInterface: Do *not* set locale to an empty string
3d1a5fa 
It causes the cursor handling to be extremely slow on MinGW.

Added in ninja-build#2321.

Fixes ninja-build#2435.
@orgads orgads mentioned this issue May 4, 2024
Merged
orgads added a commit to orgads/MINGW-packages that referenced this issue May 4, 2024
@orgads
ninja: Fix slow cursor update regression
02aadd8 
Reported in ninja-build/ninja#2435

PR waiting for approval: ninja-build/ninja#2437.
@orgads orgads mentioned this issue May 4, 2024
Closed
@jhasse jhasse added this to the 1.13.0 milestone May 5, 2024
@jhasse
Copy link
Collaborator

jhasse commented May 5, 2024

Thanks for reporting!

orgads added a commit to orgads/ninja that referenced this issue May 5, 2024
@orgads
RealDiskInterface: Do *not* set locale to an empty string
e4b74a8 
It causes the cursor handling to be extremely slow on MinGW.

Added in ninja-build#2321.

Fixes ninja-build#2435.

(cherry picked from commit 3d1a5fa)
@orgads orgads mentioned this issue May 5, 2024
Closed
@jhasse jhasse modified the milestones: 1.13.0, 1.12.1 May 11, 2024
jhasse pushed a commit that referenced this issue May 11, 2024
@orgads @jhasse
RealDiskInterface: Do *not* set locale to an empty string
aca02ab 
It causes the cursor handling to be extremely slow on MinGW.

Added in #2321.

Fixes #2435.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug windows
Projects
None yet
Milestone
1.12.1
Development

Successfully merging a pull request may close this issue.

RealDiskInterface: Do *not* set locale to an empty string orgads/ninja
2 participants
@jhasse @orgads