-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ninja triggers GLIBCXX assertion and crashes #2472
Comments
digit-google
added a commit
to digit-google/ninja
that referenced
this issue
Sep 2, 2024
The parser used asserts to verify the consistency of the deps log, which resulted in crashes in production. Replace them with correct checks and return conditions. This allows the parser to survive and report corrupted files, and Ninja to ignore the latter. + Add related unit-test. Fixes ninja-build#2472 Fixes ninja-build#2309
digit-google
added a commit
to digit-google/ninja
that referenced
this issue
Sep 3, 2024
The parser used asserts to verify the consistency of the deps log, which resulted in crashes in production. Replace them with correct checks and return conditions. This allows the parser to survive and report corrupted files, and Ninja to ignore the latter. + Add related unit-test. Fixes ninja-build#2472 Fixes ninja-build#2309
digit-google
added a commit
to digit-google/ninja
that referenced
this issue
Sep 4, 2024
The parser used asserts to verify the consistency of the deps log, which resulted in crashes in production. Replace them with correct checks and return conditions. This allows the parser to survive and report corrupted files, and Ninja to ignore the latter. + Add related unit-test. Fixes ninja-build#2472 Fixes ninja-build#2309
digit-google
added a commit
to digit-google/ninja
that referenced
this issue
Sep 4, 2024
The parser used asserts to verify the consistency of the deps log, which resulted in crashes in production. Replace them with correct checks and return conditions. This allows the parser to survive and report corrupted files, and Ninja to ignore the latter. + Add related unit-test. Fixes ninja-build#2472 Fixes ninja-build#2309
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Building one of my company's projects, I just had Ninja crash with
I don't remember changing anything on the build configuration side. I am on Ninja version
1.12.1
. Compiling the same project in a new clone of the repository in a different paths works flawlessly. It used to work in the original path until now.The error occurs in my
RelWithDebInfo
build located inpath/to/project/build/RelWithDebInfo
. A nearly identically configuredDebug
build inpath/to/project/build/Debug
builds just fine.This issue might be related to #2309, which also reports the same assertion is triggered.
Running the build in the debugger points me to
deps_log.cc
:Sadly,
i
is optimized out, but it's out of bounds.UPDATE: After reconfiguring with
cmake -S . -B build/RelWithDebInfo -G Ninja --fresh ...
the problem persisted. After completely wipingbuild/RelWithDebInfo
and regenerating the build configuration it is working again 🤷♂️The text was updated successfully, but these errors were encountered: