Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: show remaining time #1360

Closed
wants to merge 1 commit into from
Closed

Conversation

giorgijpopov
Copy link

The remaining time is added to the end of each line.

@Trass3r
Copy link

Trass3r commented Nov 9, 2018

Looks useful to me.

@jhasse
Copy link
Collaborator

jhasse commented Nov 14, 2018

Thanks for the PR! But I think that if we want to do this, it should rather be done with a new status format, see #1428.

@jhasse jhasse closed this Nov 14, 2018
@irishrover
Copy link

May be it worth to reopen this PR and refactor to utilize %E as in my #1428?
Or I can reopen and refactor my #1428 and pick changes from this PR?

@jhasse
Copy link
Collaborator

jhasse commented Nov 16, 2018

Which changes from this PR do you have in mind?

@irishrover
Copy link

Which changes from this PR do you have in mind?

The way you calculate an estimated time.

@jhasse
Copy link
Collaborator

jhasse commented Nov 30, 2018

Looks the same to me:

(total_edges_ - finished_edges_) * overall_rate_.Elapsed() / finished_edges_;
(time / finished_edges_) * (total_edges_ - finished_edges_)

@LebedevRI
Copy link
Contributor

Superseded by #1963.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants