Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed restat mtime to be set the first time restat edges are built. #1941

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Changed restat mtime to be set the first time restat edges are built. #1941

wants to merge 2 commits into from

Conversation

dmoody256
Copy link

Fixes #1940

@jhasse
Copy link
Collaborator

jhasse commented Mar 28, 2021

Can you add a unit test for #1940?

@jdrouhard
Copy link
Contributor

Can you add a unit test for #1940?

A unit test to show this would be great, and @dmoody256, could you try the branch for #1943 as a fix for #1940 first? It changes what is recorded as the output mtime in the build log.

@dmoody256
Copy link
Author

@jdrouhard @jhasse unit test added

@dmoody256 dmoody256 mentioned this pull request Mar 31, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

restat needlessly rebuilding outputs
3 participants
@dmoody256 @jhasse @jdrouhard