Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add simplified critical path scheduler to improve build times #2177

Merged
merged 22 commits into from
Feb 29, 2024
Merged

Add simplified critical path scheduler to improve build times #2177

merged 22 commits into from
Feb 29, 2024

Commits on Aug 25, 2021

  1. support explicit build order

    @nico @peterbell10
    nico authored and peterbell10 committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    4af9fc5 View commit details
    Browse the repository at this point in the history

  2. Use explicit std:: style and remove debug print statements

    @peterbell10
    peterbell10 committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    12b5b7c View commit details
    Browse the repository at this point in the history

  3. Change priority_list_ into a std::priority_queue of ready edges

    @peterbell10
    peterbell10 committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    8e23200 View commit details
    Browse the repository at this point in the history

  4. Fix critical time calculation 

    The existing algorithm doesn't work because it strictly requires that
all outputs are visited before updating an edge. So any task downstream
from a task with multiple out-edges may get ignored.

The fix is to always propagate your critical time to the next input
node, and only place it in the queue if you offer a higher critical
time.
    @peterbell10
    peterbell10 committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    2fcf403 View commit details
    Browse the repository at this point in the history

  5. clang-format diff

    @peterbell10
    peterbell10 committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    c5d355c View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2021

  1. Address review comments

    @peterbell10
    peterbell10 committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    63b0a9a View commit details
    Browse the repository at this point in the history

  2. Fix total_time computation

    @peterbell10
    peterbell10 committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    5b8d19b View commit details
    Browse the repository at this point in the history

  3. Address review comments

    @peterbell10
    peterbell10 committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    fe80637 View commit details
    Browse the repository at this point in the history

  4. Improve heuristic for unknown cost edges

    @peterbell10
    peterbell10 committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    c83167f View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2021

  1. Remove redundant include

    @peterbell10
    peterbell10 committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    77448b4 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2022

  1. Address review comments 

    1. Move EdgePriorityQueue to graph.h and inherit from priority_queue
2. Add comment about edge->critical_time()
    @peterbell10
    peterbell10 committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    24d1f5f View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into cpsched

    @peterbell10
    peterbell10 committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    1af6daf View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary whitespace

    @peterbell10
    peterbell10 committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    6ee9049 View commit details
    Browse the repository at this point in the history

  4. Add simple test for EdgeQueue

    @peterbell10
    peterbell10 committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    1128a56 View commit details
    Browse the repository at this point in the history

  5. Improve comments and retrieve edges into ready_queue directly

    @peterbell10
    peterbell10 committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    a861164 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2022

  1. Add run_time_ms accessors and more comments

    @peterbell10
    peterbell10 committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    026498f View commit details
    Browse the repository at this point in the history

  2. Add test and fix priority bug 

    AddTarget cannot add edges to the ready queue before the critical time
has been computed.
    @peterbell10
    peterbell10 committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    4bd8db1 View commit details
    Browse the repository at this point in the history

  3. Pool: sort equally-weighted edges by priority

    @peterbell10
    peterbell10 committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    a643af2 View commit details
    Browse the repository at this point in the history

  4. Rename critical_time to critical_time_ms

    @peterbell10
    peterbell10 committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    f2333b7 View commit details
    Browse the repository at this point in the history

  5. Clarify the purpose of active_edges in back-propagation

    @peterbell10
    peterbell10 committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    09d4faa View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2022

  1. Merge remote-tracking branch 'upstream/master' into cpsched-2

    @peterbell10
    peterbell10 committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    18220a3 View commit details
    Browse the repository at this point in the history

  2. Simplify scheduler to not use build log/execution time

    @peterbell10
    peterbell10 committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    29fe3ef View commit details
    Browse the repository at this point in the history