Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: semantic version. CMake DRY refactor #2244

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

scivision
Copy link
Contributor

CI: avoid nuisance warnings about outdated libraries by using semantic versions in *.yml

CMake: DRY (don't repeat yourself) by refactoring to inspect target sources and set CXX property in one place.

CMake: avoid nuisance extra CTest targets and use consistent variable name NINJA_BUILD_TESTING by using enable_testing()

@jhasse
Copy link
Collaborator

jhasse commented Feb 7, 2023

Hm ... isn't BUILD_TESTING supposed to be the clean solution to disable one's tests? Introducing our own variable sounds like a bad idea and not like the clean CMake way (not that there is one).

@scivision
Copy link
Contributor Author

Some projects choose to use ${PROJECT_NAME}_BUILD_TESTING and others use BUILD_TESTING. I'll switch it to BUILD_TESTING to avoid disruption.

@scivision scivision force-pushed the ciact branch 2 times, most recently from dfe3df3 to 2583d48 Compare April 16, 2024 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants