Order clean by path length to ensure directories can be deleted #2252
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My ninja build generator is setup to create intermediate build directories and keep track of these as build outputs in order to properly clean up the intermediate directory structure with the clean ninja target.
It is cumbersome to have to track the directory hierarchy as implicit dependencies, but not doing so results in the clean target not being able to correctly order the deletion, causing directory deletions to fail due to still having files (which will be deleted later by the clean target).
A simple solution is to defer all deletions, sort by path length and perform all deletions starting with the deepest path. That guarantees that any directory is deleted after all the files in that directory.