Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aspect ratio support #101

Merged
merged 2 commits into from
Jul 12, 2023
Merged

Add aspect ratio support #101

merged 2 commits into from
Jul 12, 2023

Conversation

sigvef
Copy link
Member

@sigvef sigvef commented Jul 1, 2023 •
edited
Loading

Add aspect ratio support

Now demos can have custom aspect ratios.

@stianjensen stianjensen self-assigned this Jul 3, 2023
stianjensen
stianjensen requested changes Jul 3, 2023
View reviewed changes
renin/src/renin.ts Show resolved Hide resolved
@sigvef
Add aspect ratio support
649cb9c 
Now demos can have custom aspect ratios.
trondkla
trondkla approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@trondkla trondkla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but should have a default value as stian said

@trondkla trondkla merged commit 7275c5a into main Jul 12, 2023
@trondkla trondkla deleted the aspect-ratio branch July 12, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stianjensen stianjensen stianjensen requested changes

@trondkla trondkla trondkla approved these changes

Assignees

@stianjensen stianjensen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sigvef @trondkla @stianjensen